Bug 38472

Summary:

[Qt] Unskip editing/inserting tests that fail due to 'x,y' differences

Product:

WebKit

Reporter:

Robert Hogan <robert>

Component:

Tools / Tests

Assignee:

Robert Hogan <robert>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, eric, kenneth, ossy, webkit.review.bot

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Pretty Diffs of Tests Where Diff shows results are purely x/y	none
Pretty Diffs of Tests Where Less Obvious That Results are OK	none
Patch	eric: review+

Robert Hogan

Reported 2010-05-03 11:06:00 PDT

Unskip the following tests: editing/inserting/12882.html editing/inserting/4840662.html editing/inserting/4875189-1.html editing/inserting/4959067.html editing/inserting/4960120-2.html editing/inserting/5002441.html editing/inserting/5058163-2.html editing/inserting/5156401-2.html editing/inserting/5418891.html editing/inserting/5510537.html editing/inserting/5549929-2.html editing/inserting/5549929-3.html editing/inserting/6633727.html editing/inserting/6703873.html editing/inserting/editable-inline-element.html editing/inserting/insert-3654864-fix.html editing/inserting/insert-3659587-fix.html editing/inserting/insert-3775316-fix.html editing/inserting/insert-3778059-fix.html editing/inserting/insert-3786362-fix.html editing/inserting/insert-3800346-fix.html editing/inserting/insert-3851164-fix.html editing/inserting/insert-3907422-fix.html editing/inserting/insert-after-delete-001.html editing/inserting/insert-at-end-01.html editing/inserting/insert-at-end-02.html editing/inserting/insert-before-link-1.html editing/inserting/insert-br-001.html editing/inserting/insert-br-002.html editing/inserting/insert-br-003.html editing/inserting/insert-br-004.html editing/inserting/insert-br-005.html editing/inserting/insert-br-006.html editing/inserting/insert-br-007.html editing/inserting/insert-br-008.html editing/inserting/insert-br-009.html editing/inserting/insert-br-at-tabspan-001.html editing/inserting/insert-br-at-tabspan-002.html editing/inserting/insert-br-at-tabspan-003.html editing/inserting/insert-br-quoted-001.html editing/inserting/insert-br-quoted-002.html editing/inserting/insert-br-quoted-003.html editing/inserting/insert-br-quoted-004.html editing/inserting/insert-br-quoted-005.html editing/inserting/insert-br-quoted-006.html editing/inserting/insert-div-001.html editing/inserting/insert-div-002.html editing/inserting/insert-div-003.html editing/inserting/insert-div-004.html editing/inserting/insert-div-005.html editing/inserting/insert-div-006.html editing/inserting/insert-div-007.html editing/inserting/insert-div-008.html editing/inserting/insert-div-009.html editing/inserting/insert-div-010.html editing/inserting/insert-div-011.html editing/inserting/insert-div-012.html editing/inserting/insert-div-013.html editing/inserting/insert-div-014.html editing/inserting/insert-div-015.html editing/inserting/insert-div-016.html editing/inserting/insert-div-017.html editing/inserting/insert-div-018.html editing/inserting/insert-div-019.html editing/inserting/insert-div-020.html editing/inserting/insert-div-021.html editing/inserting/insert-div-022.html editing/inserting/insert-div-024.html editing/inserting/insert-div-025.html editing/inserting/insert-div-026.html editing/inserting/insert-div-027.html editing/inserting/insert-paragraph-01.html editing/inserting/insert-paragraph-02.html editing/inserting/insert-paragraph-03.html editing/inserting/insert-paragraph-04.html editing/inserting/insert-paragraph-05.html editing/inserting/insert-space-in-empty-doc.html editing/inserting/insert-tab-001.html editing/inserting/insert-tab-002.html editing/inserting/insert-tab-004.html editing/inserting/insert-text-at-tabspan-001.html editing/inserting/insert-text-at-tabspan-002.html editing/inserting/insert-text-at-tabspan-003.html editing/inserting/line-break.html editing/inserting/paragraph-separator-01.html editing/inserting/paragraph-separator-02.html editing/inserting/paragraph-separator-in-table-1.html editing/inserting/paragraph-separator-in-table-2.html editing/inserting/redo.html editing/inserting/return-key-with-selection-003.html editing/inserting/typing-001.html editing/inserting/typing-002.html editing/inserting/typing-003.html editing/inserting/typing-around-br-001.html editing/inserting/typing-around-image-001.html editing/inserting/5058163-1.html editing/inserting/edited-whitespace-1.html editing/inserting/paragraph-separator-03.html editing/inserting/return-key-with-selection-001.html editing/inserting/return-key-with-selection-002.html editing/inserting/4875189-2.html

Attachments
Pretty Diffs of Tests Where Diff shows results are purely x/y (49.35 KB, application/zip) 2010-05-03 11:07 PDT, Robert Hogan	no flags	Details
Pretty Diffs of Tests Where Less Obvious That Results are OK (6.70 KB, application/zip) 2010-05-03 11:08 PDT, Robert Hogan	no flags	Details
Patch (15.66 KB, patch) 2010-05-03 11:09 PDT, Robert Hogan	eric: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Robert Hogan

Comment 1 2010-05-03 11:07:30 PDT

Created attachment 54941 [details] Pretty Diffs of Tests Where Diff shows results are purely x/y

Robert Hogan

Comment 2 2010-05-03 11:08:14 PDT

Created attachment 54942 [details] Pretty Diffs of Tests Where Less Obvious That Results are OK

Robert Hogan

Comment 3 2010-05-03 11:09:26 PDT

Created attachment 54943 [details] Patch

Eric Seidel (no email)

Comment 4 2010-05-05 22:07:09 PDT

Comment on attachment 54943 [details] Patch ok rs=me. Be sure to land and rebaseline these at a time when the tree is calm. i.e. not in the middle of the day California time. :)

WebKit Review Bot

Comment 5 2010-05-09 03:09:19 PDT

http://trac.webkit.org/changeset/59052 might have broken Qt Linux Release

Kenneth Rohde Christiansen

Comment 6 2010-05-13 11:37:44 PDT

Was this landed (judging from the comment #5). Can it be closed?

Csaba Osztrogonác

Comment 7 2010-05-14 06:10:21 PDT

(In reply to comment #6) > Was this landed (judging from the comment #5). Can it be closed? Yes, because the patch landed: http://trac.webkit.org/changeset/59052 Rebaselines of tests landed too: http://trac.webkit.org/changeset/59053 http://trac.webkit.org/changeset/59054

Note You need to log in before you can comment on or make changes to this bug.