Summary: | [WebKit2] Add generic callback mechanism | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2010-05-03 10:16:55 PDT
Created attachment 54936 [details]
patch
Comment on attachment 54936 [details]
patch
r=me!
Attachment 54936 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/API/C/WKAPICast.h:50: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:51: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:52: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:53: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:54: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:55: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:56: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:57: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:58: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:61: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:62: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:63: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:64: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:65: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:66: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:67: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKAPICast.h:68: More than one command on the same line [whitespace/newline] [4]
WebKit2/UIProcess/API/C/WKPage.cpp:151: WKPageRunJavaScriptInMainFrame_b is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit2/UIProcess/API/C/WKPage.cpp:176: WKPageRenderTreeExternalRepresentation_b is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 19 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Are these style complaint false positives? Should we exempt WebKit2/UIProcess/API/C from our C++ style guide? (Although WebKit2/UIProcess/API/C/WKAPICast.h looks like C++ and not C...) |