Bug 38471

Summary:

[WebKit2] Add generic callback mechanism

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

OS X 10.5

Attachments:

Description	Flags
patch	andersca: review+

Sam Weinig

Reported 2010-05-03 10:16:55 PDT

We should have a generic callback mechanism so we don't have to write all the boilerplate code seen in RenderTreeExternalRepresentationCallback and ScriptReturnValueCallback.

Attachments
patch (40.03 KB, patch) 2010-05-03 10:18 PDT, Sam Weinig	andersca: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2010-05-03 10:18:24 PDT

Created attachment 54936 [details] patch

Anders Carlsson

Comment 2 2010-05-03 10:23:30 PDT

Comment on attachment 54936 [details] patch r=me!

WebKit Review Bot

Comment 3 2010-05-03 10:24:24 PDT

Attachment 54936 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit2/UIProcess/API/C/WKAPICast.h:50: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:51: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:52: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:53: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:54: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:55: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:56: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:57: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:58: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:61: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:62: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:63: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:64: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:65: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:66: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:67: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKAPICast.h:68: More than one command on the same line [whitespace/newline] [4] WebKit2/UIProcess/API/C/WKPage.cpp:151: WKPageRunJavaScriptInMainFrame_b is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] WebKit2/UIProcess/API/C/WKPage.cpp:176: WKPageRenderTreeExternalRepresentation_b is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 19 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 4 2010-05-03 10:28:34 PDT

Fixed in r58684.

Adam Barth

Comment 5 2010-05-03 10:32:37 PDT

Are these style complaint false positives? Should we exempt WebKit2/UIProcess/API/C from our C++ style guide? (Although WebKit2/UIProcess/API/C/WKAPICast.h looks like C++ and not C...)

Note You need to log in before you can comment on or make changes to this bug.