Summary: | Misleading variable name in a11y test | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Mario Sanchez Prada
2010-05-03 07:58:45 PDT
Created attachment 54928 [details]
Proposed patch
Attaching a patch proposal for this
Comment on attachment 54928 [details] Proposed patch Rejecting patch 54928 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 54928, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1 Logging in as eseidel@chromium.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=54928&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=38465&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 54928 from bug 38465. ERROR: /Users/eseidel/Projects/CommitQueue/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Created attachment 56331 [details] Proposed patch (In reply to comment #2) > (From update of attachment 54928 [details]) > Rejecting patch 54928 from commit-queue. Seems I uploaded the wrong patch, lacking the "Reviewed by NOBODY" line, sorry. Now uploading the right one. Comment on attachment 56331 [details] Proposed patch Clearing flags on attachment: 56331 Committed r59818: <http://trac.webkit.org/changeset/59818> All reviewed patches have been landed. Closing bug. |