Bug 38445 – REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()

• Component: HTML Editing
• Status: RESOLVED FIXED

Another case of <rdar://problem/7552959>. Patch forthcoming.

Created attachment 54901 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 54901 [details]
Patch

> Index: WebCore/ChangeLog
> ===================================================================

> +        possible, crossing any editability boudaries. Infinite recursion is avoided by advancing all the way

Typo: "boudaries"

> Index: WebCore/dom/Position.cpp
> ===================================================================

> +static Position downstreamIgnoringEditingBoundaries(Position position)

Should this take a const Position&?

> +static Position upstreamIgnoringEditingBoundaries(Position position)

Ditto

WebCore/ChangeLog:18
 +          test for buttons with the generic and more comprehensive canHaveChildrenForEditing().

Does this part of the change need its own testcase?

r=me

(In reply to comment #2)
> > +static Position downstreamIgnoringEditingBoundaries(Position position)
> 
> Should this take a const Position&?

It’d have to be copied anyway, and this was easier to write.

>  +          test for buttons with the generic and more comprehensive
> canHaveChildrenForEditing().
> 
> Does this part of the change need its own testcase?

Existing tests crash without it.

Thanks for the review!

Fixed in <http://trac.webkit.org/projects/webkit/changeset/58665>.