Bug 38444

Summary: [Qt] GraphicsLayer caches directly composited images
Product: WebKit Reporter: Noam Rosenthal <noam>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Enhancement CC: commit-queue, eric, hausmann, jesus, jturcotte, simon.fraser
Priority: P2 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 38744    
Attachments:
Description Flags
Only cache HTML content
kenneth: review+, kenneth: commit-queue-
added comments per Kenneth's review none

Noam Rosenthal
Reported 2010-05-02 17:44:08 PDT
it could be optimized to draw them directly.
Attachments
Only cache HTML content (1.43 KB, patch)
2010-05-02 17:47 PDT, Noam Rosenthal 		kenneth: review+
kenneth: commit-queue-
DetailsFormatted DiffDiff
added comments per Kenneth's review (1.97 KB, patch)
2010-05-13 10:35 PDT, Noam Rosenthal 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Noam Rosenthal
Comment 1 2010-05-02 17:47:12 PDT
Created attachment 54894 [details] Only cache HTML content
Eric Seidel (no email)
Comment 2 2010-05-02 18:24:24 PDT
Comment on attachment 54894 [details] Only cache HTML content Looks sane. Do other ports have this optimization?
Noam Rosenthal
Comment 3 2010-05-02 18:30:42 PDT
Yes - that's what the direct-compositing API in GraphicsLayer.h is for. We've had this optimization in before, but I omitted it by mistake when I introduced another optimization
Kenneth Rohde Christiansen
Comment 4 2010-05-12 05:43:46 PDT
Comment on attachment 54894 [details] Only cache HTML content I think this deserves an explanation in the code. So please add a comment.
Noam Rosenthal
Comment 5 2010-05-13 10:35:53 PDT
Created attachment 55994 [details] added comments per Kenneth's review
WebKit Commit Bot
Comment 6 2010-05-14 18:43:44 PDT
Comment on attachment 55994 [details] added comments per Kenneth's review Clearing flags on attachment: 55994 Committed r59510: <http://trac.webkit.org/changeset/59510>
WebKit Commit Bot
Comment 7 2010-05-14 18:43:51 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 8 2010-05-16 01:03:15 PDT
Revision r59510 cherry-picked into qtwebkit-2.0 with commit ead6be782dbaa32cf9c33e21b3c32d2f78c4d0a5
Note You need to log in before you can comment on or make changes to this bug.