Bug 38441

Summary: Web Inspector: Old Style trimWhitespace() should be trim()
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Inspector (Deprecated)Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, joepeck, keishi, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Simple Fix. none

Joseph Pecoraro
Reported 2010-05-02 14:07:58 PDT
Found an occurrence of trimWhitespace in SourceFrame. This would produce an error. It was removed in: Use String.trim() instead of a regex in the Web Inspector. http://trac.webkit.org/changeset/53366 It creeped back in with: Web Inspector: migrate from SourceFrame to SourceFrame2. http://trac.webkit.org/changeset/53941
Attachments
[PATCH] Simple Fix. (1.32 KB, patch)
2010-05-02 14:15 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2010-05-02 14:15:59 PDT
Created attachment 54890 [details] [PATCH] Simple Fix. I haven't actually tried to cause this to fail. I just did a simple code audit to see that the function didn't exist any more. It could be that this case isn't even reachable anymore.
Joseph Pecoraro
Comment 2 2010-05-02 14:33:44 PDT
It looks like _evalSelectionInCallFrame is not called at all anymore? The popups cover the majority of the use cases. Should this feature be removed? If it is removed, keyboard shortcuts on the wiki will need to be updated.
WebKit Commit Bot
Comment 3 2010-05-02 14:42:15 PDT
Comment on attachment 54890 [details] [PATCH] Simple Fix. Clearing flags on attachment: 54890 Committed r58660: <http://trac.webkit.org/changeset/58660>
WebKit Commit Bot
Comment 4 2010-05-02 14:42:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.