Bug 38437

Summary: Results for editing/pasteboard/5761530-1.html are wrong
Product: WebKit Reporter: Robert Hogan <robert>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, hamaji, justin.garcia, kenneth, robert
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 41394    
Attachments:
Description Flags
Patch kenneth: review+, commit-queue: commit-queue-

Description Robert Hogan 2010-05-02 08:27:21 PDT
The expected results for editing/pasteboard/5761530-1.html are:

This tests to see that tabs are put into tab spans when they are copied individually. The pasted tab should be inside of a tab span, not a style span. To run the test manually, paste and then inspect the editable region, and ensure that there is a tab span at the beginning of the editable div.

<span class="Apple-tab-span" style="white-space: pre; ">[tab]</span><span class="Apple-tab-span" style="white-space:pre;">[ws]</span>xxx

where [tab] is a tab, and [ws] is a single space.

On Qt, the result is:


This tests to see that tabs are put into tab spans when they are copied individually. The pasted tab should be inside of a tab span, not a style span. To run the test manually, paste and then inspect the editable region, and ensure that there is a tab span at the beginning of the editable div.

<span class="Apple-tab-span" style="white-space: pre; ">[tab]</span><span class="Apple-tab-span" style="white-space:pre;">[tab]</span>xxx

Isn't this more correct? If copying a span wouldn't you expect the tab to be copied as a tab, rather than replaced with a single space?
Comment 1 Justin Garcia 2010-05-02 22:44:57 PDT
> Isn't this more correct? If copying a span wouldn't you expect the tab to be
> copied as a tab, rather than replaced with a single space?

Definitely.  When I perform the test manually everything looks OK, Paste inserts a tab and when I expect the DOM there's a tab, not a space.
Comment 2 Justin Garcia 2010-05-02 22:45:36 PDT
> when I expect the DOM

"inspect"
Comment 3 Robert Hogan 2010-06-20 11:16:12 PDT
Created attachment 59202 [details]
Patch
Comment 4 WebKit Commit Bot 2010-06-29 12:26:08 PDT
Comment on attachment 59202 [details]
Patch

Rejecting patch 59202 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1
Last 500 characters of output:
 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej
patching file LayoutTests/platform/gtk/Skipped
Hunk #1 FAILED at 5895.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej
patching file LayoutTests/platform/mac/Skipped
Hunk #1 FAILED at 295.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej
patching file LayoutTests/platform/qt/Skipped
Hunk #1 succeeded at 367 (offset -3 lines).

Full output: http://webkit-commit-queue.appspot.com/results/3294972
Comment 5 Robert Hogan 2010-06-29 14:00:14 PDT
Committed r62146: <http://trac.webkit.org/changeset/62146>
Comment 6 Alexey Proskuryakov 2010-06-29 17:11:39 PDT
+        * platform/mac/Skipped:

Please don't skip test that don't crash on Mac. We prefer to have wrong results checked in, so that we know about unexpected changes in behavior.

When there is a platform difference like this, cross-platform results should be those that we believe correct, but one can always add platform specific results to avoid skipping tests.
Comment 7 Kenneth Rohde Christiansen 2010-06-29 19:14:15 PDT
(In reply to comment #6)
> +        * platform/mac/Skipped:
> 
> Please don't skip test that don't crash on Mac. We prefer to have wrong results checked in, so that we know about unexpected changes in behavior.
> 
> When there is a platform difference like this, cross-platform results should be those that we believe correct, but one can always add platform specific results to avoid skipping tests.

Right, I will keep that in mind. Do you need a bug filled then? or what do you prefer?
Comment 8 Alexey Proskuryakov 2010-06-29 21:39:01 PDT
I think this changes to skip lists and updated results can be landed without review when there is no controversy. This isn't a huge issue.
Comment 9 Shinichiro Hamaji 2010-07-12 04:10:56 PDT
Committed r63068: <http://trac.webkit.org/changeset/63068>