Bug 38437 – Results for editing/pasteboard/5761530-1.html are wrong

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Robert Hogan]

The expected results for editing/pasteboard/5761530-1.html are:

This tests to see that tabs are put into tab spans when they are copied individually. The pasted tab should be inside of a tab span, not a style span. To run the test manually, paste and then inspect the editable region, and ensure that there is a tab span at the beginning of the editable div.

<span class="Apple-tab-span" style="white-space: pre; ">[tab]</span><span class="Apple-tab-span" style="white-space:pre;">[ws]</span>xxx

where [tab] is a tab, and [ws] is a single space.

On Qt, the result is:


This tests to see that tabs are put into tab spans when they are copied individually. The pasted tab should be inside of a tab span, not a style span. To run the test manually, paste and then inspect the editable region, and ensure that there is a tab span at the beginning of the editable div.

<span class="Apple-tab-span" style="white-space: pre; ">[tab]</span><span class="Apple-tab-span" style="white-space:pre;">[tab]</span>xxx

Isn't this more correct? If copying a span wouldn't you expect the tab to be copied as a tab, rather than replaced with a single space?

[Justin Garcia]

> Isn't this more correct? If copying a span wouldn't you expect the tab to be
> copied as a tab, rather than replaced with a single space?

Definitely.  When I perform the test manually everything looks OK, Paste inserts a tab and when I expect the DOM there's a tab, not a space.

[Justin Garcia]

> when I expect the DOM

"inspect"

[Robert Hogan]

Created attachment 59202 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 59202 [details]
Patch

Rejecting patch 59202 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1
Last 500 characters of output:
 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej
patching file LayoutTests/platform/gtk/Skipped
Hunk #1 FAILED at 5895.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/gtk/Skipped.rej
patching file LayoutTests/platform/mac/Skipped
Hunk #1 FAILED at 295.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/Skipped.rej
patching file LayoutTests/platform/qt/Skipped
Hunk #1 succeeded at 367 (offset -3 lines).

Full output: http://webkit-commit-queue.appspot.com/results/3294972

[Robert Hogan]

Committed r62146: <http://trac.webkit.org/changeset/62146>

[Alexey Proskuryakov]

+        * platform/mac/Skipped:

Please don't skip test that don't crash on Mac. We prefer to have wrong results checked in, so that we know about unexpected changes in behavior.

When there is a platform difference like this, cross-platform results should be those that we believe correct, but one can always add platform specific results to avoid skipping tests.

[Kenneth Rohde Christiansen]

(In reply to comment #6)
> +        * platform/mac/Skipped:
> 
> Please don't skip test that don't crash on Mac. We prefer to have wrong results checked in, so that we know about unexpected changes in behavior.
> 
> When there is a platform difference like this, cross-platform results should be those that we believe correct, but one can always add platform specific results to avoid skipping tests.

Right, I will keep that in mind. Do you need a bug filled then? or what do you prefer?

[Alexey Proskuryakov]

I think this changes to skip lists and updated results can be landed without review when there is no controversy. This isn't a huge issue.

[Shinichiro Hamaji]

Committed r63068: <http://trac.webkit.org/changeset/63068>