Bug 3840 – Add an option to DumpRenderTree to render into a bitmap file

• Component: Tools / Tests
• Status: VERIFIED FIXED

DumpRenderTree (or a separate WebKit tool) should have an option to render into a bitmap image and 
save it to disk. The user should be able to specify the bitmap's dimensions.

[Joost de Valk (AlthA)]

Sounds reasonable, confirming. Made it an "enhancement" and moved to p3. Mitz: if you have any reason 
for it to be p2, please comment here on your reasons :).

Created attachment 3311 [details]
add bitmap functinoality

This patch adds --width, --height, --(no)bitmap and --(no)tree options to
DumpRenderTree. If you don't specify any of them, it behaves like it currently
does. Following the options you can either give a list of filenames or a single
"-", in which case the program reads filenames from stdin, one per line.

This doesn't include any of the directory scanning, output filename
construction and bitmap diffing that svg2png does. I don't think any of that
stuff belongs in DumpRenderTree. It can either be left for the test scripts to
do (requiring a separate bitmap diffing utility) or a separate tool should be
written.

Comment on attachment 3311 [details]
add bitmap functinoality

(See previous comment)

[Eric Seidel (no email)]

Comment on attachment 3311 [details]
add bitmap functinoality

Hum... Ben was just fixing this same bug as part of:
http://bugzilla.opendarwin.org/show_bug.cgi?id=4299... He's done with
DumpKCanvasTree, and run-webkit-test changes... I had asked him to make
corresponding changes to DumpRenderTree before commiting.  You two actually
took different approaches regarding who should actually dump the files (your
change dumps them back over stdout, ben's dump's directly to a file).  We
should make sure to reconcile the changes and land one singular solution which
works the same for DumpKCanvasTree as well as DumpRenderTreee and has
corresponding run-webkit-test changes as well.

[Darin Adler]

Comment on attachment 3311 [details]
add bitmap functinoality

I like the approach here. Even if we do more later, we should definitely land
this patch.

[Eric Seidel (no email)]

commited.