Bug 38384

Summary: [GStreamer] endless loop after playback ended
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: WebKitGTKAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, atwilson, eric.carlson, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
URL: http://blogs.gnome.org/xan/files/2010/04/woot.ogg
Attachments:
Description Flags
proposed patch+test eric: review+

Philippe Normand
Reported 2010-04-30 02:58:19 PDT
Linked video will play fine but the player fails to get its duration. So when playback ends the player sets the duration to the current playback position and pause the pipeline. But duration() still returns inf because the m_mediaDurationKnown is still false. This triggers and infinite loop because HTMLMediaElement::endedPlayback will always return false (isnan(dur) check still passing). This flag needs to be set to true in didEnd() if m_mediaDuration is known.
Attachments
proposed patch+test (4.11 KB, patch)
2010-04-30 03:07 PDT, Philippe Normand 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2010-04-30 03:07:47 PDT
Created attachment 54790 [details] proposed patch+test
Eric Seidel (no email)
Comment 2 2010-04-30 11:42:25 PDT
Comment on attachment 54790 [details] proposed patch+test Looks reasonable.
WebKit Review Bot
Comment 3 2010-05-03 07:28:24 PDT
http://trac.webkit.org/changeset/58671 might have broken Qt Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/58672 http://trac.webkit.org/changeset/58671
Philippe Normand
Comment 4 2010-05-03 08:20:03 PDT
Landed in r58671 and skipped the test in r58674. See also https://bugs.webkit.org/show_bug.cgi?id=38466
Note You need to log in before you can comment on or make changes to this bug.