| Summary: | notifications should have dir and replaceId attributes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | John Gregg <johnnyg> | ||||
| Component: | WebCore Misc. | Assignee: | John Gregg <johnnyg> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, commit-queue, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
John Gregg
2010-04-29 11:28:21 PDT
Created attachment 54726 [details]
Patch
Comment on attachment 54726 [details]
Patch
r=me with 2 notes (can be done on landing):
- please add the link to the spec version you implementing to the bug notes
- it would be nice to tell in the ChangeLog that tests are diasabled for all but Chromium.
The draft spec for Web Notifications is http://dev.w3.org/2006/webapi/WebNotifications/publish/ Comment on attachment 54726 [details] Patch Rejecting patch 54726 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Dmitry Titov', u'--force']" exit_code: 1 Last 500 characters of output: fuzz 3. patching file LayoutTests/fast/notifications/notifications-replace-expected.txt patching file LayoutTests/fast/notifications/notifications-replace.html patching file LayoutTests/fast/notifications/notifications-rtl-expected.txt patching file LayoutTests/fast/notifications/notifications-rtl.html patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 2875. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Full output: http://webkit-commit-queue.appspot.com/results/1975016 Committed r58765: <http://trac.webkit.org/changeset/58765> http://trac.webkit.org/changeset/58765 might have broken Qt Linux Release |