Bug 38336

Summary:

notifications should have dir and replaceId attributes

Product:

WebKit

Reporter:

John Gregg <johnnyg>

Component:

WebCore Misc.

Assignee:

John Gregg <johnnyg>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	dimich: review+, commit-queue: commit-queue-

John Gregg

Reported 2010-04-29 11:28:21 PDT

Two new attributes have been added to the w3c draft spec; webkit should add these.

Attachments
Patch (9.68 KB, patch) 2010-04-29 12:03 PDT, John Gregg	dimich: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

John Gregg

Comment 1 2010-04-29 12:03:38 PDT

Created attachment 54726 [details] Patch

Dmitry Titov

Comment 2 2010-04-29 15:23:06 PDT

Comment on attachment 54726 [details] Patch r=me with 2 notes (can be done on landing): - please add the link to the spec version you implementing to the bug notes - it would be nice to tell in the ChangeLog that tests are diasabled for all but Chromium.

John Gregg

Comment 3 2010-04-29 16:33:21 PDT

The draft spec for Web Notifications is http://dev.w3.org/2006/webapi/WebNotifications/publish/

WebKit Commit Bot

Comment 4 2010-05-02 01:25:15 PDT

Comment on attachment 54726 [details] Patch Rejecting patch 54726 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Dmitry Titov', u'--force']" exit_code: 1 Last 500 characters of output: fuzz 3. patching file LayoutTests/fast/notifications/notifications-replace-expected.txt patching file LayoutTests/fast/notifications/notifications-replace.html patching file LayoutTests/fast/notifications/notifications-rtl-expected.txt patching file LayoutTests/fast/notifications/notifications-rtl.html patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 2875. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Full output: http://webkit-commit-queue.appspot.com/results/1975016

John Gregg

Comment 5 2010-05-04 10:21:32 PDT

Committed r58765: <http://trac.webkit.org/changeset/58765>

WebKit Review Bot

Comment 6 2010-05-04 10:52:31 PDT

http://trac.webkit.org/changeset/58765 might have broken Qt Linux Release

Note You need to log in before you can comment on or make changes to this bug.