Bug 38335

Summary: Implement skewX() and skewY() for CSSMatrix
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: CSSAssignee: Ariya Hidayat <ariya.hidayat>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ariya.hidayat, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Implement CSSMatrix.skew()
none
Implement CSSMatrix.skew()
none
Implement skewX() and skewY() for CSSMatrix. none

Chris Marrin
Reported 2010-04-29 11:05:21 PDT
This is in the spec, but not in our implementation
Attachments
Implement CSSMatrix.skew() (6.82 KB, patch)
2010-12-22 19:12 PST, Ariya Hidayat 		no flags
DetailsFormatted DiffDiff
Implement CSSMatrix.skew() (7.71 KB, patch)
2010-12-22 19:43 PST, Ariya Hidayat 		no flags
DetailsFormatted DiffDiff
Implement skewX() and skewY() for CSSMatrix. (8.52 KB, patch)
2010-12-22 22:10 PST, Ariya Hidayat 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ariya Hidayat
Comment 1 2010-12-22 19:12:17 PST
Created attachment 77296 [details] Implement CSSMatrix.skew()
Ariya Hidayat
Comment 2 2010-12-22 19:37:33 PST
Comment on attachment 77296 [details] Implement CSSMatrix.skew() Forgot to add one more file.
Ariya Hidayat
Comment 3 2010-12-22 19:43:42 PST
Created attachment 77300 [details] Implement CSSMatrix.skew()
Simon Fraser (smfr)
Comment 4 2010-12-22 21:12:29 PST
Comment on attachment 77300 [details] Implement CSSMatrix.skew() skew(x, y) was removed from the spec. There's skewX() and skewY() now. See http://dev.w3.org/csswg/css3-2d-transforms/.
Ariya Hidayat
Comment 5 2010-12-22 22:10:57 PST
Created attachment 77305 [details] Implement skewX() and skewY() for CSSMatrix.
Ariya Hidayat
Comment 6 2010-12-22 22:56:14 PST
Comment on attachment 77305 [details] Implement skewX() and skewY() for CSSMatrix. Clearing flags on attachment: 77305 Committed r74539: <http://trac.webkit.org/changeset/74539>
Ariya Hidayat
Comment 7 2010-12-22 22:56:26 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2010-12-23 02:33:07 PST
http://trac.webkit.org/changeset/74539 might have broken Qt Linux Release
Ariya Hidayat
Comment 9 2010-12-23 08:44:37 PST
> http://trac.webkit.org/changeset/74539 might have broken Qt Linux Release False alarm. Everything looks OK now.
Note You need to log in before you can comment on or make changes to this bug.