Bug 38333

Summary:

[Qt] Enable DOMWindow constructor for HTMLProgressElement

Product:

WebKit

Reporter:

Yael <yael>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, webkit.review.bot

Priority:

Keywords:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Yael

Reported 2010-04-29 09:35:17 PDT

Qt requires adding ENABLE_PROGRESS_TAG to the flag FEATURE_DEFINES_JAVASCRIPT in order for this to work.

Attachments
Patch (5.64 KB, patch) 2010-04-29 11:12 PDT, Yael	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yael

Comment 1 2010-04-29 11:12:59 PDT

Created attachment 54721 [details] Patch

WebKit Commit Bot

Comment 2 2010-04-30 01:41:50 PDT

Comment on attachment 54721 [details] Patch Clearing flags on attachment: 54721 Committed r58563: <http://trac.webkit.org/changeset/58563>

WebKit Commit Bot

Comment 3 2010-04-30 01:41:55 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 4 2010-04-30 02:04:15 PDT

http://trac.webkit.org/changeset/58563 might have broken Qt Linux Release

Yael

Comment 5 2010-04-30 05:32:45 PDT

(In reply to comment #4) > http://trac.webkit.org/changeset/58563 might have broken Qt Linux Release I think this is a false alarm.

Yael

Comment 6 2010-04-30 06:27:07 PDT

(In reply to comment #5) > (In reply to comment #4) > > http://trac.webkit.org/changeset/58563 might have broken Qt Linux Release > > I think this is a false alarm. No, it was not a false alarm. My patch required regenerating DOM bindings. Over night this was triggered so that's why I did not see failures in the morning.

Note You need to log in before you can comment on or make changes to this bug.