Bug 38295

Summary:

Define resource target types for worker and sharedWorker main resources.

Product:

WebKit

Reporter:

Michael Nordman <michaeln>

Component:

WebCore Misc.

Assignee:

Michael Nordman <michaeln>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
new TargetTypes	none

Michael Nordman

Reported 2010-04-28 17:18:44 PDT

This is a subtask of http://code.google.com/p/chromium/issues/detail?id=39368 Add ResourceRequestBase TargetTypes for worker and shared worker main resources.

Attachments
new TargetTypes (8.90 KB, patch) 2010-04-28 17:32 PDT, Michael Nordman	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Michael Nordman

Comment 1 2010-04-28 17:32:03 PDT

Created attachment 54641 [details] new TargetTypes

Dmitry Titov

Comment 2 2010-04-29 13:43:06 PDT

Comment on attachment 54641 [details] new TargetTypes r=me

WebKit Commit Bot

Comment 3 2010-04-29 17:46:01 PDT

Comment on attachment 54641 [details] new TargetTypes Rejecting patch 54641 from commit-queue. michaeln@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights.

WebKit Commit Bot

Comment 4 2010-05-02 01:39:31 PDT

Comment on attachment 54641 [details] new TargetTypes Clearing flags on attachment: 54641 Committed r58647: <http://trac.webkit.org/changeset/58647>

WebKit Commit Bot

Comment 5 2010-05-02 01:39:35 PDT

All reviewed patches have been landed. Closing bug.

WebKit Review Bot

Comment 6 2010-05-02 02:05:54 PDT

http://trac.webkit.org/changeset/58647 might have broken Chromium Mac Release

Kent Tamura

Comment 7 2010-05-02 04:38:25 PDT

(In reply to comment #6) > http://trac.webkit.org/changeset/58647 might have broken Chromium Mac Release Fixed by r58649.

Note You need to log in before you can comment on or make changes to this bug.