Bug 38291

Summary: CSS counters in :before pseudo-elements do not always update
Product: WebKit Reporter: Nate Whetsell <nathan.whetsell>
Component: CSSAssignee: Julien Chaffraix <jchaffraix>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jchaffraix
Priority: P2 Keywords: HasReduction
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Test HTML document
none
Patch none

Nate Whetsell
Reported 2010-04-28 16:01:36 PDT
Created attachment 54634 [details] Test HTML document When using more than one CSS counter and generating counted elements using JavaScript, counters placed in the content of a :before pseudo-element do not update themselves, but counters placed in the content of an :after pseudo-element do. I will attach a test HTML document illustrating the problem. In this test document, the number of red "xxx" strings should be counted; there are counters placed before and after the x's. The counters placed after the x's update appropriately as elements are added. The counters placed before the x's do not update as expected. In Firefox, both counters show the same number as elements are added.
Attachments
Test HTML document (1.02 KB, text/html)
2010-04-28 16:01 PDT, Nate Whetsell 		no flags
Details
Patch (4.11 KB, patch)
2011-04-28 13:29 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nate Whetsell
Comment 1 2010-04-28 16:11:19 PDT
This issue may be related to bug #11033.
Julien Chaffraix
Comment 2 2010-09-13 17:38:34 PDT
Confirmed on nightly build (Chromium Windows).
Julien Chaffraix
Comment 3 2011-04-27 16:25:21 PDT
Some refactoring went into the CSS counter code and this bug got solved (tested on Qt/Linux ToT and Chromium Canary build). It is still reproducible in Chromium stable. I will turn the test case into an regression test and have it landed.
Nate Whetsell
Comment 4 2011-04-27 18:41:38 PDT
For posterity's sake, the last Mac OS X nightly build where I can reproduce the bug is r81689. The bug is fixed in r81756.
Julien Chaffraix
Comment 5 2011-04-28 13:29:59 PDT
Created attachment 91544 [details] Patch
Julien Chaffraix
Comment 6 2011-04-28 15:11:06 PDT
Comment on attachment 91544 [details] Patch Thanks for confirming Nate!
WebKit Commit Bot
Comment 7 2011-04-28 19:24:33 PDT
Comment on attachment 91544 [details] Patch Clearing flags on attachment: 91544 Committed r85288: <http://trac.webkit.org/changeset/85288>
WebKit Commit Bot
Comment 8 2011-04-28 19:24:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.