Bug 3829

Summary: GW: Several additions to KWQColor
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 3250    
Attachments:
Description Flags
necessary additions to KWQColor
mjs: review-
Per mjs and my talks -- a much larger patch, making cgColor, nsColor free functions. mjs: review+

Eric Seidel (no email)
Reported 2005-07-02 20:45:49 PDT
This patch includes several additions to KWQColor: CIColor support (when WebKit is linked against CoreImage) CIColor *getCIColor() const; qRed, qGreen, qBlue support explicit QColor(const QString &) -- performs expected css color input (like KDE does) void getRgbaF(float *, float *, float *, float *) const; -- matching QT4
Attachments
necessary additions to KWQColor (4.51 KB, patch)
2005-07-02 20:46 PDT, Eric Seidel (no email) 		mjs: review-
DetailsFormatted DiffDiff
Per mjs and my talks -- a much larger patch, making cgColor, nsColor free functions. (21.41 KB, patch)
2005-07-05 02:59 PDT, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-07-02 20:46:30 PDT
Created attachment 2768 [details] necessary additions to KWQColor
Maciej Stachowiak
Comment 2 2005-07-03 01:16:43 PDT
Comment on attachment 2768 [details] necessary additions to KWQColor > +bool parseHexColor(const QString &name, QRgb &rgb) { No need to make this a member function, suggest just making it a vanilla static function (maybe inline since it is used exactly once). Also, don't put the open brace on the line with the function prototype (this occurs elsehwere in the file as well). I suggest making the CGColor conversion a free function, and moving hte CIColor conversion out of this file entirely to avoid requiring an SVG_SUPPORT ifdef.
Maciej Stachowiak
Comment 3 2005-07-03 01:43:27 PDT
Comment on attachment 2768 [details] necessary additions to KWQColor > +bool parseHexColor(const QString &name, QRgb &rgb) { No need to make this a member function, suggest just making it a vanilla static function (maybe inline since it is used exactly once). Also, don't put the open brace on the line with the function prototype (this occurs elsehwere in the file as well). I suggest making the CGColor conversion a free function, and moving hte CIColor conversion out of this file entirely to avoid requiring an SVG_SUPPORT ifdef.
Eric Seidel (no email)
Comment 4 2005-07-05 02:59:01 PDT
Created attachment 2802 [details] Per mjs and my talks -- a much larger patch, making cgColor, nsColor free functions.
Maciej Stachowiak
Comment 5 2005-07-07 00:37:07 PDT
Comment on attachment 2802 [details] Per mjs and my talks -- a much larger patch, making cgColor, nsColor free functions. r=me
Note You need to log in before you can comment on or make changes to this bug.