GW: Several additions to KWQColor

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

This patch includes several additions to KWQColor:

CIColor support (when WebKit is linked against CoreImage)
CIColor *getCIColor() const;

qRed, qGreen, qBlue support
explicit QColor(const QString &) -- performs expected css color input (like KDE does)
void getRgbaF(float *, float *, float *, float *) const; -- matching QT4

[Eric Seidel (no email)]

Created attachment 2768 [details]
necessary additions to KWQColor

[Maciej Stachowiak]

Comment on attachment 2768 [details]
necessary additions to KWQColor

> +bool parseHexColor(const QString &name, QRgb &rgb) {

No need to make this a member function, suggest just making it a vanilla static
function (maybe inline since it is used exactly once).

Also, don't put the open brace on the line with the function prototype (this
occurs elsehwere in the file as well).

I suggest making the CGColor conversion a free function, and moving hte CIColor
conversion out of this file entirely to avoid requiring an SVG_SUPPORT ifdef.

[Maciej Stachowiak]

Comment on attachment 2768 [details]
necessary additions to KWQColor

> +bool parseHexColor(const QString &name, QRgb &rgb) {

No need to make this a member function, suggest just making it a vanilla static
function (maybe inline since it is used exactly once).

Also, don't put the open brace on the line with the function prototype (this
occurs elsehwere in the file as well).

I suggest making the CGColor conversion a free function, and moving hte CIColor
conversion out of this file entirely to avoid requiring an SVG_SUPPORT ifdef.

[Eric Seidel (no email)]

Created attachment 2802 [details]
Per mjs and my talks -- a much larger patch, making cgColor, nsColor free functions.

[Maciej Stachowiak]

Comment on attachment 2802 [details]
Per mjs and my talks -- a much larger patch, making cgColor, nsColor free functions.

r=me