|Summary:||[chromium] Make WebThemeEngine::paint take a const ref of ExtraParams|
|Product:||WebKit||Reporter:||John Abd-El-Malek <jam>|
|Component:||Platform||Assignee:||John Abd-El-Malek <jam>|
|Severity:||Normal||CC:||dglazkov, fishd, webkit.review.bot|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description John Abd-El-Malek 2010-04-27 22:16:31 PDT
I checked it in as a pointer because I was getting compiler errors, but I think they were unrelated because it works now as a const ref.
Comment 1 John Abd-El-Malek 2010-04-27 22:18:20 PDT
Created attachment 54523 [details] Proposed patch
Comment 2 WebKit Review Bot 2010-04-27 22:23:15 PDT
Attachment 54523 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/chromium/public/WebThemeEngine.h:116: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return]  Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 John Abd-El-Malek 2010-04-27 22:38:03 PDT
Created attachment 54524 [details] ran dos2unix on the file
Comment 4 John Abd-El-Malek 2010-04-27 22:39:50 PDT
ok I remember the problem. It's because I wanted to cast it from one struct to another that has the same layout, and I couldn't do it with references. Although probably if I cast to a pointer and back it'll work.