| Summary: | [chromium] Make WebThemeEngine::paint take a const ref of ExtraParams | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | John Abd-El-Malek <jam> | ||||||
| Component: | Platform | Assignee: | John Abd-El-Malek <jam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dglazkov, fishd, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
John Abd-El-Malek
2010-04-27 22:16:31 PDT
Created attachment 54523 [details]
Proposed patch
Attachment 54523 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/chromium/public/WebThemeEngine.h:116: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1]
Suppressing further [whitespace/carriage_return] reports for this file.
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 54524 [details]
ran dos2unix on the file
ok I remember the problem. It's because I wanted to cast it from one struct to another that has the same layout, and I couldn't do it with references. Although probably if I cast to a pointer and back it'll work. |