Bug 38242

Summary: [chromium] Make WebThemeEngine::paint take a const ref of ExtraParams
Product: WebKit Reporter: John Abd-El-Malek <jam>
Component: PlatformAssignee: John Abd-El-Malek <jam>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed patch
none
ran dos2unix on the file fishd: review+, fishd: commit-queue+

John Abd-El-Malek
Reported 2010-04-27 22:16:31 PDT
I checked it in as a pointer because I was getting compiler errors, but I think they were unrelated because it works now as a const ref.
Attachments
Proposed patch (1.15 KB, patch)
2010-04-27 22:18 PDT, John Abd-El-Malek 		no flags
DetailsFormatted DiffDiff
ran dos2unix on the file (9.46 KB, patch)
2010-04-27 22:38 PDT, John Abd-El-Malek 		fishd: review+
fishd: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Abd-El-Malek
Comment 1 2010-04-27 22:18:20 PDT
Created attachment 54523 [details] Proposed patch
WebKit Review Bot
Comment 2 2010-04-27 22:23:15 PDT
Attachment 54523 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/chromium/public/WebThemeEngine.h:116: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
John Abd-El-Malek
Comment 3 2010-04-27 22:38:03 PDT
Created attachment 54524 [details] ran dos2unix on the file
John Abd-El-Malek
Comment 4 2010-04-27 22:39:50 PDT
ok I remember the problem. It's because I wanted to cast it from one struct to another that has the same layout, and I couldn't do it with references. Although probably if I cast to a pointer and back it'll work.
John Abd-El-Malek
Comment 5 2010-04-28 12:43:08 PDT
Committed r58422
Note You need to log in before you can comment on or make changes to this bug.