Bug 3823

Summary: GW: Fix KWQStaticDeleter to comply with modern KDE API
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P4    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 3250    
Attachments:
Description Flags
fixes our KWQStaticDeleter mjs: review+

Eric Seidel (no email)
Reported 2005-07-02 20:07:51 PDT
KWQStatic deleter only takes two parameters (one optional) when the KDE one takes 3 (one optiona). This can cause unexpected crashes due to silent pointer -> bool casting. This patch fixes our KWQStaticDeleter to comply with the KDE one.
Attachments
fixes our KWQStaticDeleter (1.30 KB, patch)
2005-07-02 20:10 PDT, Eric Seidel (no email) 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2005-07-02 20:10:31 PDT
Created attachment 2762 [details] fixes our KWQStaticDeleter
Maciej Stachowiak
Comment 2 2005-07-03 01:59:36 PDT
Comment on attachment 2762 [details] fixes our KWQStaticDeleter r=me
Maciej Stachowiak
Comment 3 2005-07-03 02:02:14 PDT
Comment on attachment 2762 [details] fixes our KWQStaticDeleter r=me
Note You need to log in before you can comment on or make changes to this bug.