Bug 38225

Summary: run-bindings-tests doesn't work in an SVN checkout
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, jamesr, yaar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Adam Barth
Reported 2010-04-27 15:23:08 PDT
run-bindings-tests doesn't work in an SVN checkout
Attachments
Patch (1.08 KB, patch)
2010-04-27 15:23 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (2.27 KB, patch)
2010-04-27 15:51 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.27 KB, patch)
2010-04-27 16:06 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-27 15:23:44 PDT
Created attachment 54460 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-27 15:25:50 PDT
Comment on attachment 54460 [details] Patch This seems like a bug in detect_scm_system and shoudl have a test.
Adam Barth
Comment 3 2010-04-27 15:42:04 PDT
Darn you for making me run test-webkitpy --all. I'm going to go read a book. :)
Adam Barth
Comment 4 2010-04-27 15:51:43 PDT
Created attachment 54464 [details] Patch
Eric Seidel (no email)
Comment 5 2010-04-27 15:54:24 PDT
Comment on attachment 54464 [details] Patch You can probably get the tmp folder from getcwd() or from self._svn_repository or whatever it's set as. I think I probably would have fixed SVN's usage instead of the caller of in_working_directory, since git's seems to take relative paths just fine. typo: + # I wanted to asser that we got the right path, but there was some
Adam Barth
Comment 6 2010-04-27 16:06:11 PDT
Created attachment 54467 [details] Patch for landing
WebKit Commit Bot
Comment 7 2010-04-27 21:49:49 PDT
Comment on attachment 54467 [details] Patch for landing Clearing flags on attachment: 54467 Committed r58376: <http://trac.webkit.org/changeset/58376>
WebKit Commit Bot
Comment 8 2010-04-27 21:49:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.