Bug 38225

Summary: run-bindings-tests doesn't work in an SVN checkout
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, jamesr, yaar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Description Adam Barth 2010-04-27 15:23:08 PDT 
run-bindings-tests doesn't work in an SVN checkout
Comment 1 Adam Barth 2010-04-27 15:23:44 PDT 
Created attachment 54460 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-27 15:25:50 PDT 
Comment on attachment 54460 [details]
Patch

This seems like a bug in detect_scm_system and shoudl have a test.
Comment 3 Adam Barth 2010-04-27 15:42:04 PDT 
Darn you for making me run test-webkitpy --all.  I'm going to go read a book.  :)
Comment 4 Adam Barth 2010-04-27 15:51:43 PDT 
Created attachment 54464 [details]
Patch
Comment 5 Eric Seidel (no email) 2010-04-27 15:54:24 PDT 
Comment on attachment 54464 [details]
Patch

You can probably get the tmp folder from getcwd() or from self._svn_repository or whatever it's set as.

I think I probably would have fixed SVN's usage instead of the caller of in_working_directory, since git's seems to take relative paths just fine.

typo:
+        # I wanted to asser that we got the right path, but there was some
Comment 6 Adam Barth 2010-04-27 16:06:11 PDT 
Created attachment 54467 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2010-04-27 21:49:49 PDT 
Comment on attachment 54467 [details]
Patch for landing

Clearing flags on attachment: 54467

Committed r58376: <http://trac.webkit.org/changeset/58376>
Comment 8 WebKit Commit Bot 2010-04-27 21:49:54 PDT 
All reviewed patches have been landed.  Closing bug.