Bug 38223

Summary: Remove obsolete custom bindings file
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, yaar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Description Adam Barth 2010-04-27 15:10:13 PDT 
Remove obsolete custom bindings file
Comment 1 Adam Barth 2010-04-27 15:11:16 PDT 
Created attachment 54459 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-27 15:21:06 PDT 
Comment on attachment 54459 [details]
Patch

There are more, but OK.
Comment 3 Adam Barth 2010-04-27 15:32:54 PDT 
Comment on attachment 54459 [details]
Patch

More build systems or more files to remove?
Comment 4 Eric Seidel (no email) 2010-04-27 15:39:13 PDT 
Probably both. :)  But I meant more files to remove.
Comment 5 Eric Seidel (no email) 2010-04-27 15:43:14 PDT 
grep -L WebCore bindings/js

Shows some header files needing removal:

bindings/js/JSCSSStyleDeclarationCustom.h
bindings/js/JSHistoryCustom.h
bindings/js/JSHTMLAppletElementCustom.h
bindings/js/JSHTMLEmbedElementCustom.h
bindings/js/JSHTMLInputElementCustom.h
bindings/js/JSHTMLObjectElementCustom.h
bindings/js/JSLocationCustom.h
bindings/js/JSStorageCustom.h


grep -r -L "::" bindings/js/*.cpp 

Shows some likely candidates as well:

bindings/js/JSAbstractWorkerCustom.cpp
bindings/js/JSCDATASectionCustom.cpp
bindings/js/JSCSSValueCustom.cpp
bindings/js/JSDocumentFragmentCustom.cpp
bindings/js/JSEventSourceCustom.cpp
bindings/js/JSPluginElementFunctions.cpp
bindings/js/JSTextCustom.cpp
Comment 6 Adam Barth 2010-04-27 15:58:33 PDT 
> bindings/js/JSDocumentFragmentCustom.cpp

Of the cpp files, only this one looked ready to remove.
Comment 7 Adam Barth 2010-04-27 16:03:56 PDT 
Created attachment 54466 [details]
Patch
Comment 8 Eric Seidel (no email) 2010-04-27 16:05:39 PDT 
Comment on attachment 54466 [details]
Patch

OK.  We can go back and remove the headers later. :)
Comment 9 WebKit Commit Bot 2010-04-27 22:31:12 PDT 
Comment on attachment 54466 [details]
Patch

Clearing flags on attachment: 54466

Committed r58379: <http://trac.webkit.org/changeset/58379>
Comment 10 WebKit Commit Bot 2010-04-27 22:31:18 PDT 
All reviewed patches have been landed.  Closing bug.