Bug 38223

Summary: Remove obsolete custom bindings file
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, yaar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2010-04-27 15:10:13 PDT
Remove obsolete custom bindings file
Attachments
Patch (18.29 KB, patch)
2010-04-27 15:11 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (26.82 KB, patch)
2010-04-27 16:03 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-04-27 15:11:16 PDT
Created attachment 54459 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-27 15:21:06 PDT
Comment on attachment 54459 [details] Patch There are more, but OK.
Adam Barth
Comment 3 2010-04-27 15:32:54 PDT
Comment on attachment 54459 [details] Patch More build systems or more files to remove?
Eric Seidel (no email)
Comment 4 2010-04-27 15:39:13 PDT
Probably both. :) But I meant more files to remove.
Eric Seidel (no email)
Comment 5 2010-04-27 15:43:14 PDT
grep -L WebCore bindings/js Shows some header files needing removal: bindings/js/JSCSSStyleDeclarationCustom.h bindings/js/JSHistoryCustom.h bindings/js/JSHTMLAppletElementCustom.h bindings/js/JSHTMLEmbedElementCustom.h bindings/js/JSHTMLInputElementCustom.h bindings/js/JSHTMLObjectElementCustom.h bindings/js/JSLocationCustom.h bindings/js/JSStorageCustom.h grep -r -L "::" bindings/js/*.cpp Shows some likely candidates as well: bindings/js/JSAbstractWorkerCustom.cpp bindings/js/JSCDATASectionCustom.cpp bindings/js/JSCSSValueCustom.cpp bindings/js/JSDocumentFragmentCustom.cpp bindings/js/JSEventSourceCustom.cpp bindings/js/JSPluginElementFunctions.cpp bindings/js/JSTextCustom.cpp
Adam Barth
Comment 6 2010-04-27 15:58:33 PDT
> bindings/js/JSDocumentFragmentCustom.cpp Of the cpp files, only this one looked ready to remove.
Adam Barth
Comment 7 2010-04-27 16:03:56 PDT
Created attachment 54466 [details] Patch
Eric Seidel (no email)
Comment 8 2010-04-27 16:05:39 PDT
Comment on attachment 54466 [details] Patch OK. We can go back and remove the headers later. :)
WebKit Commit Bot
Comment 9 2010-04-27 22:31:12 PDT
Comment on attachment 54466 [details] Patch Clearing flags on attachment: 54466 Committed r58379: <http://trac.webkit.org/changeset/58379>
WebKit Commit Bot
Comment 10 2010-04-27 22:31:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.