Bug 38182

Summary:

Remove custom bindings for TreeWalker

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, eric, sam, webkit.review.bot, yaar

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	eric: review+

Description Adam Barth 2010-04-27 01:40:51 PDT

Remove custom bindings for TreeWalker

Comment 1 Adam Barth 2010-04-27 01:43:18 PDT

Created attachment 54397 [details]
Patch

Comment 2 WebKit Review Bot 2010-04-27 01:46:18 PDT

Attachment 54397 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:190:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:192:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:199:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:201:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:203:  g_res is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/bindings/scripts/test/JS/JSTestObj.cpp:148:  Missing spaces around |  [whitespace/operators] [3]
WebCore/bindings/scripts/test/JS/JSTestObj.cpp:149:  Missing spaces around |  [whitespace/operators] [3]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h:89:  Extra space before ( in function call  [whitespace/parens] [4]
WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h:92:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 9 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Eric Seidel (no email) 2010-04-27 01:49:53 PDT

Comment on attachment 54397 [details]
Patch

Looks right to me.

Comment 4 Eric Seidel (no email) 2010-04-27 01:54:10 PDT

I filed bug 38185 about the GObject warnings.

Comment 5 Eric Seidel (no email) 2010-04-27 01:54:51 PDT

NodeIterator is also fixable this way. :)

Comment 6 WebKit Review Bot 2010-04-27 02:12:06 PDT

Attachment 54397 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1920009

Comment 7 Adam Barth 2010-04-27 02:12:29 PDT

Committed r58298: <http://trac.webkit.org/changeset/58298>