Bug 38178

Summary: [Chromium] Remove deprecated form of didChangeLocationWithinPage
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: WebKit APIAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch
none
v2 patch none

Darin Fisher (:fishd, Google)
Reported 2010-04-27 00:08:12 PDT
[Chromium] Remove deprecated form of didChangeLocationWithinPage
Attachments
v1 patch (5.08 KB, patch)
2010-04-27 00:13 PDT, Darin Fisher (:fishd, Google) 		no flags
DetailsFormatted DiffDiff
v2 patch (5.08 KB, patch)
2010-04-27 10:24 PDT, Darin Fisher (:fishd, Google) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2010-04-27 00:13:23 PDT
Created attachment 54391 [details] v1 patch The changes to WebViewHost.{h,cpp} mirror the changes made here: http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.cc?r1=41850&r2=41849&pathrev=41850
WebKit Review Bot
Comment 2 2010-04-27 01:06:02 PDT
Attachment 54391 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1882079
Darin Fisher (:fishd, Google)
Comment 3 2010-04-27 10:24:15 PDT
Created attachment 54428 [details] v2 patch Fixed DRT bustage.
Dimitri Glazkov (Google)
Comment 4 2010-04-27 10:25:53 PDT
Comment on attachment 54428 [details] v2 patch r=me.
WebKit Commit Bot
Comment 5 2010-04-27 17:28:36 PDT
Comment on attachment 54428 [details] v2 patch Clearing flags on attachment: 54428 Committed r58358: <http://trac.webkit.org/changeset/58358>
WebKit Commit Bot
Comment 6 2010-04-27 17:28:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.