Bug 38178

Summary: [Chromium] Remove deprecated form of didChangeLocationWithinPage
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: WebKit APIAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch
none
v2 patch none

Description Darin Fisher (:fishd, Google) 2010-04-27 00:08:12 PDT
[Chromium] Remove deprecated form of didChangeLocationWithinPage
Comment 1 Darin Fisher (:fishd, Google) 2010-04-27 00:13:23 PDT
Created attachment 54391 [details]
v1 patch

The changes to WebViewHost.{h,cpp} mirror the changes made here:
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.cc?r1=41850&r2=41849&pathrev=41850
Comment 2 WebKit Review Bot 2010-04-27 01:06:02 PDT
Attachment 54391 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1882079
Comment 3 Darin Fisher (:fishd, Google) 2010-04-27 10:24:15 PDT
Created attachment 54428 [details]
v2 patch

Fixed DRT bustage.
Comment 4 Dimitri Glazkov (Google) 2010-04-27 10:25:53 PDT
Comment on attachment 54428 [details]
v2 patch

r=me.
Comment 5 WebKit Commit Bot 2010-04-27 17:28:36 PDT
Comment on attachment 54428 [details]
v2 patch

Clearing flags on attachment: 54428

Committed r58358: <http://trac.webkit.org/changeset/58358>
Comment 6 WebKit Commit Bot 2010-04-27 17:28:42 PDT
All reviewed patches have been landed.  Closing bug.