Bug 38125

Summary: View modes names in CSSValueKeywords.in
Product: WebKit Reporter: Luiz Agostini <luiz@webkit.org>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned@lists.webkit.org>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue@webkit.org, hausmann@webkit.org, laszlo.gombos@webkit.org
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
patch 1
none
patch 2 none

Description From 2010-04-26 07:15:07 PST
View mode names has changed in previous patch but CSSValueKeywords.in file was not updated. Layout tests should fail but they do not because of bug 38116.
------- Comment #1 From 2010-04-26 07:21:24 PST -------
Created an attachment (id=54294) [details]
patch 1
------- Comment #2 From 2010-04-26 07:22:57 PST -------
Looks good, but should we sort these strings when possible ?
------- Comment #3 From 2010-04-26 07:32:34 PST -------
(In reply to comment #2)
> Looks good, but should we sort these strings when possible ?

no problem. :)
------- Comment #4 From 2010-04-26 07:38:30 PST -------
Created an attachment (id=54299) [details]
patch 2
------- Comment #5 From 2010-04-26 09:21:52 PST -------
(From update of attachment 54299 [details])
Clearing flags on attachment: 54299

Committed r58258: <http://trac.webkit.org/changeset/58258>
------- Comment #6 From 2010-04-26 09:21:58 PST -------
All reviewed patches have been landed.  Closing bug.
------- Comment #7 From 2010-05-05 08:14:03 PST -------
Revision r58258 cherry-picked into qtwebkit-2.0 with commit ddf1a58c83038dfe71ff66417d4a4a8d0c3a2bb5