Bug 38084

Summary: fast/events/touch has non-standard script test wrappers
Product: WebKit Reporter: Darin Adler <darin>
Component: Tools / TestsAssignee: Ben Murdoch <benm>
Status: RESOLVED FIXED    
Severity: Normal CC: benm, commit-queue, hausmann, jamesr, kim.1.gronholm
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 37830    
Attachments:
Description Flags
Proposed patch none

Darin Adler
Reported 2010-04-24 14:26:12 PDT
'fast/events/touch/basic-single-touch-events.html' 'fast/events/touch/send-oncancel-event.html' 'fast/events/touch/basic-multi-touch-events.html' 'fast/events/touch/touch-target.html' All of these wrappers get overwritten by the standard wrapper if you use the make-script-test-wrappers script. Such tests should not use the script-tests directory.
Attachments
Proposed patch (9.62 KB, patch)
2010-04-29 08:05 PDT, Ben Murdoch 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Murdoch
Comment 1 2010-04-24 21:53:40 PDT
I can look at this. The tests you list above need to be run asynchronously (and so need js-test-post-function.js) whereas the other touch tests run synchronously (so use js-test-post.js). I propose refactoring the synchronous tests to be asynchronous and and updating the TEMPLATE.html to include js-test-post-function.js so that the tests you list have their wrappers generated correctly. Also of interest is bug 37830, where the current patch proposes rather than including js-test-post-function.js at the top of TEMPLATE.html (i.e. so it is parsed before the test runs) move it to the bottom of TEMPLATE.html and have the test run onload. I prefer including the js file at the top but am open to discussing the other alternatives. Thanks, Ben
Darin Adler
Comment 2 2010-04-24 22:26:01 PDT
Custom tests are OK, ones that work like script-tests but don't work with the standard wrapper, but if you make them you need to put them in resources rather than script-tests so the script won't overwrite their wrappers. Once that short term task is done, it would also be nice to find a way to adjust things so that these can use standard wrappers by changing these tests, changing the standard wrappers, or both.
Ben Murdoch
Comment 3 2010-04-29 08:05:13 PDT
Created attachment 54708 [details] Proposed patch Tidy up the touch layout tests by making TEMPLATE.html generate asynchronous style tests and move the synchronous test into the resources directory (consider it a custom test).
Darin Adler
Comment 4 2010-04-29 13:36:55 PDT
Comment on attachment 54708 [details] Proposed patch Looks fine. r=me
WebKit Commit Bot
Comment 5 2010-05-02 00:50:50 PDT
Comment on attachment 54708 [details] Proposed patch Clearing flags on attachment: 54708 Committed r58644: <http://trac.webkit.org/changeset/58644>
WebKit Commit Bot
Comment 6 2010-05-02 00:50:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.