Summary: | svn-apply: suppress misleading "error: pathspec ..." message when adding binary file | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Jerdonek <cjerdonek> | ||||||||
Component: | Tools / Tests | Assignee: | Chris Jerdonek <cjerdonek> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | cjerdonek, dbates, eric | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Chris Jerdonek
2010-04-23 09:26:20 PDT
Created attachment 55475 [details]
Proposed patch
Created attachment 55476 [details]
Proposed patch
Corrected ChangeLog.
Created attachment 55477 [details]
Proposed patch 3
Fixed a code comment: STDOUT -> STDERR.
Comment on attachment 55477 [details] Proposed patch 3 We should add a comment to reference the Perldocs about this. > +sub callSilently($@) { > + my ($func, @args) = @_; > + > + open(OLDERR, ">&STDERR"); > + close(STDERR); > + my @returnValue = &$func(@args); > + open(STDERR, ">&OLDERR"); > + close(OLDERR); # FIXME: Is this necessary? > + > + return @returnValue; > +} > + We should probably change this to use exitStatus. We can do this in another patch, but then we should add a FIXME comment. > +sub gitKnowsOfFile($) > +{ > + my $path = shift; > + > + `git ls-files --error-unmatch -- $path`; > + my $exitCode = $? >> 8; > + return $exitCode == 0; > +} r=me. Committed: http://trac.webkit.org/changeset/59043 |