Bug 38006

Summary: Change lifetime of JSC::IdentifierTables used by WebCores to match AtomicStringTable
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch
none
Fix erroneous svn merge resolution
none
Chromium build fix ggaren: review+

Description Gavin Barraclough 2010-04-22 14:00:59 PDT 
Presently JSC's IdentifierTables are owned by the JSGlobalData.  For JSGlobalData objects created via the API this should continue to be the case, but for the JSGlobalData objects used by WebCore (the main thread's common global data, and those for workers) use a IdentifierTable provided (and owned) by wtfThreadData.  This allow the lifetime of these IdentifierTable to match those of the corresponding AtomicStringTables.
Comment 1 Gavin Barraclough 2010-04-22 14:02:32 PDT 
Created attachment 54093 [details]
The patch
Comment 2 Gavin Barraclough 2010-04-22 14:08:00 PDT 
Created attachment 54094 [details]
Fix erroneous svn merge resolution
Comment 3 Eric Seidel (no email) 2010-04-22 14:10:45 PDT 
Attachment 54093 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1882003
Comment 4 WebKit Review Bot 2010-04-22 14:33:11 PDT 
Attachment 54094 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1840035
Comment 5 Gavin Barraclough 2010-04-22 14:36:49 PDT 
Created attachment 54098 [details]
Chromium build fix
Comment 6 Geoffrey Garen 2010-04-22 15:17:56 PDT 
Comment on attachment 54098 [details]
Chromium build fix

r=me?
Comment 7 Geoffrey Garen 2010-04-22 15:18:16 PDT 
Please run testjsglue.
Comment 8 Gavin Barraclough 2010-04-22 17:12:01 PDT 
fixed in r58133