Bug 38006

Summary: Change lifetime of JSC::IdentifierTables used by WebCores to match AtomicStringTable
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, ggaren, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch
none
Fix erroneous svn merge resolution
none
Chromium build fix ggaren: review+

Gavin Barraclough
Reported 2010-04-22 14:00:59 PDT
Presently JSC's IdentifierTables are owned by the JSGlobalData. For JSGlobalData objects created via the API this should continue to be the case, but for the JSGlobalData objects used by WebCore (the main thread's common global data, and those for workers) use a IdentifierTable provided (and owned) by wtfThreadData. This allow the lifetime of these IdentifierTable to match those of the corresponding AtomicStringTables.
Attachments
The patch (11.55 KB, patch)
2010-04-22 14:02 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Fix erroneous svn merge resolution (11.47 KB, patch)
2010-04-22 14:08 PDT, Gavin Barraclough 		no flags
DetailsFormatted DiffDiff
Chromium build fix (11.50 KB, patch)
2010-04-22 14:36 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-04-22 14:02:32 PDT
Created attachment 54093 [details] The patch
Gavin Barraclough
Comment 2 2010-04-22 14:08:00 PDT
Created attachment 54094 [details] Fix erroneous svn merge resolution
Eric Seidel (no email)
Comment 3 2010-04-22 14:10:45 PDT
Attachment 54093 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/1882003
WebKit Review Bot
Comment 4 2010-04-22 14:33:11 PDT
Attachment 54094 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1840035
Gavin Barraclough
Comment 5 2010-04-22 14:36:49 PDT
Created attachment 54098 [details] Chromium build fix
Geoffrey Garen
Comment 6 2010-04-22 15:17:56 PDT
Comment on attachment 54098 [details] Chromium build fix r=me?
Geoffrey Garen
Comment 7 2010-04-22 15:18:16 PDT
Please run testjsglue.
Gavin Barraclough
Comment 8 2010-04-22 17:12:01 PDT
fixed in r58133
Note You need to log in before you can comment on or make changes to this bug.