| Summary: | Improve code generator scripts to handle OR ('|') condition in the extended attributes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jian Li <jianli> | ||||
| Component: | WebCore JavaScript | Assignee: | Jian Li <jianli> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, dglazkov, dimich, sam, yaar | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 37840 | ||||||
| Attachments: |
|
||||||
Created attachment 54079 [details]
Proposed Patch
Comment on attachment 54079 [details]
Proposed Patch
WebCore/bindings/scripts/CodeGeneratorJS.pm:298
+ } else {
Maybe it's better to be explicit here? You're assuming that not & is |
Nice removal Of copy/paste code. Please address the above before landing.
Fixed and landed at http://trac.webkit.org/changeset/58193. It occurs to me that you didn't add a test to our spiffy new generated code testing harness. Can you please add one in a follow up bug? Where is it located? I will add one. (In reply to comment #5) > Where is it located? I will add one. I'm not 100% sure. Look for a file with the word "test" and idl in it's name. I think there is a run-bindings-tests script somewhere too. This is all very new. |
The current code generator scripts support using AND ('&') condition in the extended attributes of an interface. We need to also add support for OR '|' condition, like in FileError interface case: interface [ Conditional=FILE_READER|FILE_WRITER ] FileError { In addition, the condition operator is not supported in the extended attributes of properties/methods of an interface. We need to fix this.