Bug 37975

Summary: webkit-patch can't fetch attachments on security bugs
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+

Description Adam Barth 2010-04-21 23:52:30 PDT
webkit-patch can't fetch attachments on security bugs
Comment 1 Adam Barth 2010-04-21 23:53:57 PDT
Created attachment 54032 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-04-21 23:57:01 PDT
Comment on attachment 54032 [details]
Patch

Yay!
Comment 3 Adam Barth 2010-04-21 23:59:31 PDT
Committed r58066: <http://trac.webkit.org/changeset/58066>
Comment 4 Eric Seidel (no email) 2010-04-23 14:32:54 PDT
This broke a whole bunch of scm tests:

======================================================================
ERROR: test_apply_small_binary_patch (webkitpy.common.checkout.scm_unittest.SVNTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 539, in test_apply_small_binary_patch
    self.checkout.apply_patch(patch_file)
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 124, in apply_patch
    run_command(args, input=patch.contents())
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/bugzilla.py", line 122, in contents
    return self._bug._bugzilla.fetch_attachment_contents(self.id())
AttributeError: 'NoneType' object has no attribute '_bugzilla'

======================================================================
ERROR: test_apply_svn_patch (webkitpy.common.checkout.scm_unittest.SVNTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 545, in test_apply_svn_patch
    patch = self._create_patch(_svn_diff("-r4:3"))
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 82, in _svn_diff
    return _make_diff("svn", *args)
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 78, in _make_diff
    return run_command([command, "diff"] + args, decode_output=False)
TypeError: can only concatenate list (not "tuple") to list

======================================================================
ERROR: test_apply_svn_patch_force (webkitpy.common.checkout.scm_unittest.SVNTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 551, in test_apply_svn_patch_force
    patch = self._create_patch(_svn_diff("-r2:4"))
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 82, in _svn_diff
    return _make_diff("svn", *args)
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 78, in _make_diff
    return run_command([command, "diff"] + args, decode_output=False)
TypeError: can only concatenate list (not "tuple") to list

======================================================================
ERROR: test_svn_apply (webkitpy.common.checkout.scm_unittest.SVNTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 476, in test_svn_apply
    self.checkout.apply_patch(self._create_patch(one_line_overlap_patch))
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 124, in apply_patch
    run_command(args, input=patch.contents())
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/bugzilla.py", line 122, in contents
    return self._bug._bugzilla.fetch_attachment_contents(self.id())
AttributeError: 'NoneType' object has no attribute '_bugzilla'

======================================================================
ERROR: test_svn_apply_git_patch (webkitpy.common.checkout.scm_unittest.SVNTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 594, in test_svn_apply_git_patch
    self._shared_test_svn_apply_git_patch()
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 329, in _shared_test_svn_apply_git_patch
    self.checkout.apply_patch(self._create_patch(git_binary_addition))
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 124, in apply_patch
    run_command(args, input=patch.contents())
  File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/bugzilla.py", line 122, in contents
    return self._bug._bugzilla.fetch_attachment_contents(self.id())
AttributeError: 'NoneType' object has no attribute '_bugzilla'

----------------------------------------------------------------------
Ran 426 tests in 313.016s
Comment 5 Adam Barth 2010-04-23 18:58:52 PDT
> 313s

Sorry about that.  I wish the ECM tests were faster so we could run them all the time.