Bug 37971

Summary: [chromium] gyp_webkit should be executable
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch hamaji: review+

Tony Chang
Reported 2010-04-21 22:44:53 PDT
[chromium] gyp_webkit should be executable
Attachments
Patch (1.04 KB, patch)
2010-04-21 22:45 PDT, Tony Chang 		hamaji: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-04-21 22:45:13 PDT
Created attachment 54024 [details] Patch
Tony Chang
Comment 2 2010-04-21 22:48:11 PDT
For the most part, this isn't that important since gyp_webkit is run directly by update-webkit --chromium. However, on Linux, the Makefile tries to be clever and rerun gyp_webkit if one of the .gyp files changes.
Shinichiro Hamaji
Comment 3 2010-04-21 23:36:33 PDT
Comment on attachment 54024 [details] Patch OK
Tony Chang
Comment 4 2010-04-21 23:50:15 PDT
Committed r58065: <http://trac.webkit.org/changeset/58065>
Note You need to log in before you can comment on or make changes to this bug.