| Summary: | [Qt] QtLauncher: make FPS measurement accurate | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Noam Rosenthal <noam> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | CLOSED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, hausmann, loulockman8, webkit.review.bot | ||||||||
| Priority: | P2 | Keywords: | Performance, Qt | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | All | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 35784 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Noam Rosenthal
2010-04-21 10:40:28 PDT
Created attachment 53969 [details]
correct fps measurement
Attachment 53969 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/QtLauncher/fpsmeasure.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/QtLauncher/fpsmeasure.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
WebKitTools/QtLauncher/fpsmeasure.cpp:42: Missing space after , [whitespace/comma] [3]
WebKitTools/QtLauncher/fpsmeasure.h:28: #ifndef header guard has wrong style, please use: fpsmeasure_h [build/header_guard] [5]
WebKitTools/QtLauncher/fpsmeasure.h:33: Alphabetical sorting problem. [build/include_order] [4]
WebKitTools/QtLauncher/fpsmeasure.h:36: This { should be at the end of the previous line [whitespace/braces] [4]
WebKitTools/QtLauncher/fpsmeasure.h:40: Use 0 instead of NULL. [readability/null] [5]
Total errors found: 7 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 53972 [details]
fix some style issues
one of the style issues cannot be fixed - fixed all the rest.
Attachment 53972 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/QtLauncher/fpsmeasure.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 53988 [details]
Fixed namings and added comments
Attachment 53988 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKitTools/QtLauncher/fpstimer.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebKitTools/QtLauncher/fpstimer.h:28: #ifndef header guard has wrong style, please use: fpstimer_h [build/header_guard] [5]
Total errors found: 2 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 53988 [details] Fixed namings and added comments Clearing flags on attachment: 53988 Committed r58047: <http://trac.webkit.org/changeset/58047> All reviewed patches have been landed. Closing bug. |