Bug 37924

Summary: Web Inspector: slow scroll speed of Timeline in case of many timeline marks
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric, pfeldman, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[patch] initial version. none

Description Ilya Tikhonovsky 2010-04-21 07:43:55 PDT
if we have significant amount of timeline marks then we have significant scrolling speed degradation. (2k marks)
Comment 1 Ilya Tikhonovsky 2010-04-21 08:12:56 PDT
Created attachment 53959 [details]
[patch] initial version.
Comment 2 Pavel Feldman 2010-04-21 15:14:26 PDT
Comment on attachment 53959 [details]
[patch] initial version.

Note that this does not address gmail's slowness. There are 1800 marks generated upon initial gmail load, i.e. we create 1800 elements. This obviously will not scale no matter what we do to scrolling. I was thinking of fixing it by introducing a canvas element instead of separate divs per record. Feel free to land your patch, but I don't think we should close the bug yet.
Comment 3 Eric Seidel (no email) 2010-04-21 18:14:28 PDT
Attachment 53959 [details] was posted by a committer and has review+, assigning to Ilya Tikhonovsky for commit.
Comment 4 Ilya Tikhonovsky 2010-04-21 22:14:06 PDT
(In reply to comment #2)
> (From update of attachment 53959 [details])
> Note that this does not address gmail's slowness. There are 1800 marks
> generated upon initial gmail load, i.e. we create 1800 elements. This obviously
> will not scale no matter what we do to scrolling. I was thinking of fixing it
> by introducing a canvas element instead of separate divs per record. Feel free
> to land your patch, but I don't think we should close the bug yet.

Everything was ok but when I created 2k marks by markTimeline I got scrolling speed slowed down as you described. The reason of that was the fact that each of these marks had additional DOM elements in timeline pane grid and timeline overview grid. 

As result for that use case we have not more then 100 visible rows in timeline panel and 2k x 2 additional  DOM elements recreated and reattached for the each scroll event. 

I've checked this use case by 10k events and now the scrolling speed is fine.
Comment 5 WebKit Commit Bot 2010-04-22 04:22:11 PDT
Comment on attachment 53959 [details]
[patch] initial version.

Clearing flags on attachment: 53959

Committed r58087: <http://trac.webkit.org/changeset/58087>
Comment 6 WebKit Commit Bot 2010-04-22 04:22:16 PDT
All reviewed patches have been landed.  Closing bug.