Bug 37888

Summary:

IDLParser.pm exhausts system resources with open2

Product:

WebKit

Reporter:

Kartikaya Gupta <lists.bugzilla>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

commit-queue, staikos

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows XP

Attachments:

Description	Flags
Patch that adds a call to waitpid to the parser	darin: review-
Proposed patch, now with change description	abarth: review-
Now with changelog patch as well	darin: review+
Patch updated with link to this bug	none
Attempt #2, without the missing linebreak this time	none

Kartikaya Gupta

Reported 2010-04-20 14:21:58 PDT

When building WebCore, IDL files are parsed and binding files are generated using the code in WebCore/bindings/scripts. Specifically, IDLParser.pm in this folder uses the open2 call to invoke a preprocessor on the IDL file. If multiple IDL files are parsed in a tight loop, the code dies after 64 IDL files because it exhausts the process IDs available. The error message that it dies with is "Can't spawn-NOWAIT: resource temporarily unavailable".

Attachments
Patch that adds a call to waitpid to the parser (669 bytes, patch) 2010-04-21 07:27 PDT, Kartikaya Gupta	darin: review-	Details Formatted Diff Diff
Proposed patch, now with change description (1.38 KB, patch) 2010-04-21 16:10 PDT, Kartikaya Gupta	abarth: review-	Details Formatted Diff Diff
Now with changelog patch as well (1.31 KB, patch) 2010-04-30 11:42 PDT, Kartikaya Gupta	darin: review+	Details Formatted Diff Diff
Patch updated with link to this bug (1.35 KB, patch) 2010-04-30 20:06 PDT, Kartikaya Gupta	no flags	Details Formatted Diff Diff
Attempt #2, without the missing linebreak this time (1.35 KB, patch) 2010-04-30 20:27 PDT, Kartikaya Gupta	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

George Staikos

Comment 1 2010-04-20 18:34:53 PDT

Please attach the patch :)

Kartikaya Gupta

Comment 2 2010-04-21 07:27:33 PDT

Created attachment 53953 [details] Patch that adds a call to waitpid to the parser

Darin Adler

Comment 3 2010-04-21 07:52:53 PDT

Comment on attachment 53953 [details] Patch that adds a call to waitpid to the parser Change looks good. Needs a change log so review-.

Kartikaya Gupta

Comment 4 2010-04-21 16:10:53 PDT

Created attachment 54000 [details] Proposed patch, now with change description Not sure if "git format-patch" is an acceptable patch format here but I don't have webkit set up in svn and it looks like at least some of the other patches in the commit queue are in this format.

Darin Adler

Comment 5 2010-04-21 17:59:45 PDT

Comment on attachment 54000 [details] Proposed patch, now with change description The change log entry needs to be in the WebCore/ChangeLog file.

Adam Barth

Comment 6 2010-04-22 12:44:03 PDT

Comment on attachment 54000 [details] Proposed patch, now with change description No changelog.

Kartikaya Gupta

Comment 7 2010-04-30 11:42:37 PDT

Created attachment 54814 [details] Now with changelog patch as well Updated with Changelog patch

Kartikaya Gupta

Comment 8 2010-04-30 19:59:19 PDT

Comment on attachment 54814 [details] Now with changelog patch as well Whoops, noticed my Changelog description doesn't reference this bug. Will upload another patch with the link.

Kartikaya Gupta

Comment 9 2010-04-30 20:06:14 PDT

Created attachment 54845 [details] Patch updated with link to this bug

Kartikaya Gupta

Comment 10 2010-04-30 20:27:27 PDT

Created attachment 54846 [details] Attempt #2, without the missing linebreak this time

WebKit Commit Bot

Comment 11 2010-05-02 05:47:16 PDT

Comment on attachment 54846 [details] Attempt #2, without the missing linebreak this time Clearing flags on attachment: 54846 Committed r58653: <http://trac.webkit.org/changeset/58653>

WebKit Commit Bot

Comment 12 2010-05-02 05:47:21 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.