Bug 37844

Summary:

[Qt] Image::drawTiled animations does not work

Product:

WebKit

Reporter:

Zoltan Herczeg <zherczeg>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

CLOSED FIXED

Severity:

Normal

CC:

commit-queue, hausmann

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
proposed fix	none

Description Zoltan Herczeg 2010-04-20 01:52:09 PDT

There is no strict order requirement between calling nativeImageForCurrentFrame() and startAnimation(). Qt requires startAnimation() must be called before nativeImageForCurrentFrame(). This patch removes this order requirement

Comment 1 Zoltan Herczeg 2010-04-20 02:01:11 PDT

Created attachment 53786 [details]
proposed fix

Comment 2 Kenneth Rohde Christiansen 2010-04-20 07:19:37 PDT

Comment on attachment 53786 [details]
proposed fix

LGTM

Comment 3 WebKit Commit Bot 2010-04-21 07:34:50 PDT

Comment on attachment 53786 [details]
proposed fix

Clearing flags on attachment: 53786

Committed r57979: <http://trac.webkit.org/changeset/57979>

Comment 4 WebKit Commit Bot 2010-04-21 07:34:55 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Simon Hausmann 2010-06-16 01:38:07 PDT

Revision r57979 cherry-picked into qtwebkit-2.0 with commit 1faaef83bb16df3b349f0ba610bdc7bbdc5197d4