Summary: | [Qt] Multitouch mocking in QtLauncher doesn't work with QGraphicsView | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kim Grönholm <kim.1.gronholm> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | CLOSED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric, hausmann, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 35784 | ||||||
Attachments: |
|
Description
Kim Grönholm
2010-04-19 13:11:24 PDT
Created attachment 53713 [details]
Fix multi-touch mocking in QtLauncher when using QGraphicsView.
Comment on attachment 53713 [details]
Fix multi-touch mocking in QtLauncher when using QGraphicsView.
Rejecting patch 53713 from commit-queue.
Unexpected failure when landing patch! Please file a bug against webkit-patch.
Failed to run "['WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', '53713', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
', 'commit', '--all', '-F', '-'], input=message)
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 85, in run_command
return Executive().run_command(*args, **kwargs)
File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/common/system/executive.py", line 186, in run_command
string_to_communicate = str(input)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf6' in position 18: ordinal not in range(128)
Committed r57897: <http://trac.webkit.org/changeset/57897> Revision r57897 cherry-picked into qtwebkit-2.0 with commit 98e5667203fbe3366c3758d4da000ad5943ae32f The Qt windows builder is busted. This appears to be the only possibly related change. In file included from ..\..\..\..\WebKitTools\QtLauncher\/webview.h:38, from ..\..\..\..\WebKitTools\QtLauncher\webview.cpp:33: ..\..\include\QtWebKit/qgraphicswebview.h:1:95: error: T:/WindowsDebug/buildslave/windows-qt-debug/build/WebKit/qt/Api/qgraphicswebview.h: No such file or directory In file included from ..\..\..\..\WebKitTools\QtLauncher\webview.cpp:33: ..\..\..\..\WebKitTools\QtLauncher\/webview.h:55: error: expected class-name before '{' token ..\..\..\..\WebKitTools\QtLauncher\/webview.h: In constructor 'GraphicsWebView::GraphicsWebView(QGraphicsItem*)': Could be that it was broken for a while but that the incremental rebuilds didn't rebuild QtLauncher I suspect that's exactly the case. I suspect that QtLauncher's dependencies are not properly expressed in the build system. Should we roll this out Simon, or is there an easy fix? Waiting for the Qt bot to finish rolling. If it fails I'll start a rollout of this. The bot rolled green. Sorry for the trouble with the commit-queue and webkit-patch. You ran into bug 37765, which hopefully will be fixed tomorrow. |