Bug 37812

Summary: Assertion failure when appcache/fail-on-update.html is run twice in a row
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 43506    
Bug Blocks:    
Attachments:
Description Flags
work in progress
none
proposed fix abarth: review+

Description Alexey Proskuryakov 2010-04-19 12:15:52 PDT 
run-webkit-tests --repeat 2 http/tests/appcache/fail-on-update.html

This often fails an assertion in associateDocumentLoaderWithCache(), as an obsolete cache gets associated with a document. This seems to be a mistake in the spec, e-mailed <http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/025975.html>.
Comment 1 Alexey Proskuryakov 2010-08-12 13:37:42 PDT 
Spec fixed in <http://html5.org/tools/web-apps-tracker?from=5285&to=5286>.
Comment 2 Alexey Proskuryakov 2010-08-17 03:05:21 PDT 
Created attachment 64568 [details]
work in progress

It's easy to apply the spec changes, but my test uncovered several other bugs. This patch fixes those, but the test still crashes randomly, possibly due to the same issue as bug 43506.
Comment 3 Alexey Proskuryakov 2010-10-04 16:02:15 PDT 
Created attachment 69709 [details]
proposed fix
Comment 4 Adam Barth 2010-10-04 16:06:22 PDT 
Comment on attachment 69709 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=69709&action=review

Hum...  This change is a bit mysterious to me, but ap tells me that no one really understands appcache and he's looking for more of a sanity check.

> LayoutTests/http/tests/appcache/resources/fail-on-update-2.php:4
> +$tmpFile = sys_get_temp_dir() . "/" . "fail_on_update_state";

Does sys_get_temp_dir give you something specific to webkit?
Comment 5 Alexey Proskuryakov 2010-10-04 16:13:05 PDT 
Committed <http://trac.webkit.org/changeset/69048>.