Bug 37810

Summary: Canvas overloads cleanup
Product: WebKit Reporter: Yaar Schnitman <yaar>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, japhet, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Yaar Schnitman
Reported 2010-04-19 10:53:44 PDT
Canvas overloads cleanup
Attachments
Patch (14.47 KB, patch)
2010-04-19 11:02 PDT, Yaar Schnitman 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yaar Schnitman
Comment 1 2010-04-19 11:02:57 PDT
Created attachment 53691 [details] Patch
Yaar Schnitman
Comment 2 2010-04-19 11:03:32 PDT
Comment on attachment 53691 [details] Patch Please cq+ if ok.
WebKit Review Bot
Comment 3 2010-04-19 11:07:01 PDT
Attachment 53691 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/v8/test/V8TestObj.cpp:308: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Nate Chapin
Comment 4 2010-04-19 15:22:56 PDT
Comment on attachment 53691 [details] Patch Ok.
WebKit Commit Bot
Comment 5 2010-04-20 07:16:42 PDT
Comment on attachment 53691 [details] Patch Clearing flags on attachment: 53691 Committed r57889: <http://trac.webkit.org/changeset/57889>
WebKit Commit Bot
Comment 6 2010-04-20 07:16:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.