Bug 37809

Summary: REGRESSION (r57796): run-webkit-tests fails with spaces in the path
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Fix run-webkit-tests when there are spaces in the path abarth: review+

Adam Roben (:aroben)
Reported 2010-04-19 10:41:34 PDT
REGRESSION (r57796): run-webkit-tests fails with spaces in the path
Attachments
Patch (1.05 KB, patch)
2010-04-19 10:42 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Fix run-webkit-tests when there are spaces in the path (1.20 KB, patch)
2010-04-19 11:32 PDT, Adam Roben (:aroben) 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-04-19 10:42:50 PDT
Created attachment 53690 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-04-19 11:21:17 PDT
Comment on attachment 53690 [details] Patch I'm going to put up a new patch that explains what's going on here better.
Adam Roben (:aroben)
Comment 3 2010-04-19 11:32:56 PDT
Created attachment 53694 [details] Fix run-webkit-tests when there are spaces in the path
Adam Barth
Comment 4 2010-04-19 11:34:27 PDT
Comment on attachment 53694 [details] Fix run-webkit-tests when there are spaces in the path Ok. Perl is insane.
Eric Seidel (no email)
Comment 5 2010-04-19 12:21:24 PDT
Comment on attachment 53694 [details] Fix run-webkit-tests when there are spaces in the path Sorry for the break. I'm not sure I understand. How does this flatten the @ARGV array into the args passed to exec?
Adam Roben (:aroben)
Comment 6 2010-04-19 12:28:45 PDT
Committed r57825: <http://trac.webkit.org/changeset/57825>
Adam Roben (:aroben)
Comment 7 2010-04-19 12:39:48 PDT
(In reply to comment #5) > (From update of attachment 53694 [details]) > I'm not sure I understand. How does this flatten the @ARGV array into the args > passed to exec? Perl does that automagically for you. $ perl -e 'my @foo = ("1", "2", "3"); my @bar = (@foo, "4", "5", "6"); print scalar(@bar), "\n"' 6 Scary, eh?
Note You need to log in before you can comment on or make changes to this bug.