Bug 37809

Summary: REGRESSION (r57796): run-webkit-tests fails with spaces in the path
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Fix run-webkit-tests when there are spaces in the path abarth: review+

Description Adam Roben (:aroben) 2010-04-19 10:41:34 PDT
REGRESSION (r57796): run-webkit-tests fails with spaces in the path
Comment 1 Adam Roben (:aroben) 2010-04-19 10:42:50 PDT
Created attachment 53690 [details]
Patch
Comment 2 Adam Roben (:aroben) 2010-04-19 11:21:17 PDT
Comment on attachment 53690 [details]
Patch

I'm going to put up a new patch that explains what's going on here better.
Comment 3 Adam Roben (:aroben) 2010-04-19 11:32:56 PDT
Created attachment 53694 [details]
Fix run-webkit-tests when there are spaces in the path
Comment 4 Adam Barth 2010-04-19 11:34:27 PDT
Comment on attachment 53694 [details]
Fix run-webkit-tests when there are spaces in the path

Ok.  Perl is insane.
Comment 5 Eric Seidel (no email) 2010-04-19 12:21:24 PDT
Comment on attachment 53694 [details]
Fix run-webkit-tests when there are spaces in the path

Sorry for the break.

I'm not sure I understand.  How does this flatten the @ARGV array into the args passed to exec?
Comment 6 Adam Roben (:aroben) 2010-04-19 12:28:45 PDT
Committed r57825: <http://trac.webkit.org/changeset/57825>
Comment 7 Adam Roben (:aroben) 2010-04-19 12:39:48 PDT
(In reply to comment #5)
> (From update of attachment 53694 [details])
> I'm not sure I understand.  How does this flatten the @ARGV array into the args
> passed to exec?

Perl does that automagically for you.

$ perl -e 'my @foo = ("1", "2", "3"); my @bar = (@foo, "4", "5", "6"); print scalar(@bar), "\n"'
6

Scary, eh?