| Summary: | Sandbox option does not work (typo) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Forney <mforney> | ||||||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Attachments: |
|
||||||||||
If this patch had a ChangeLog entry and the review flag set to ? I’d have been more than happy to r+ it and mark it as ready to be committed. By the way, you can see <http://webkit.org/coding/contributing.html> for some more info about that. Created attachment 53631 [details]
Fixes the sandbox option
Sorry about that. Here is an updated patch.
Attachment 53631 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
ChangeLog:9: Line contains tab character. [whitespace/tab] [5]
ChangeLog:10: Line contains tab character. [whitespace/tab] [5]
ChangeLog:11: Line contains tab character. [whitespace/tab] [5]
Total errors found: 3 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 53637 [details]
Fixes the sandbox option
Fixed the tabs.
Comment on attachment 53637 [details]
Fixes the sandbox option
lgtm, r+.
Comment on attachment 53637 [details] Fixes the sandbox option Clearing flags on attachment: 53637 Committed r57801: <http://trac.webkit.org/changeset/57801> All reviewed patches have been landed. Closing bug. |
Created attachment 53623 [details] Fixes the sandbox option When you try to build WebKit with --{enable,disable}-sandbox, configure complains because it is not a valid option. This is because it is declared with AC_ARG_ENABLE(ruby ...) in configure.ac, a cut and paste error from the ruby option. Configure output: configure: WARNING: unrecognized options: --disable-sandbox The attached patch fixes this issue.