Bug 37762

Summary:

Sandbox option does not work (typo)

Product:

WebKit

Reporter:

Michael Forney <mforney>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Fixes the sandbox option	none
Fixes the sandbox option	none
Fixes the sandbox option	none

Michael Forney

Reported 2010-04-17 20:54:30 PDT

Created attachment 53623 [details] Fixes the sandbox option When you try to build WebKit with --{enable,disable}-sandbox, configure complains because it is not a valid option. This is because it is declared with AC_ARG_ENABLE(ruby ...) in configure.ac, a cut and paste error from the ruby option. Configure output: configure: WARNING: unrecognized options: --disable-sandbox The attached patch fixes this issue.

Attachments
Fixes the sandbox option (798 bytes, patch) 2010-04-17 20:54 PDT, Michael Forney	no flags	Details Formatted Diff Diff
Fixes the sandbox option (1.37 KB, patch) 2010-04-18 12:50 PDT, Michael Forney	no flags	Details Formatted Diff Diff
Fixes the sandbox option (1.39 KB, patch) 2010-04-18 15:19 PDT, Michael Forney	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mark Rowe (bdash)

Comment 1 2010-04-18 06:17:11 PDT

If this patch had a ChangeLog entry and the review flag set to ? I’d have been more than happy to r+ it and mark it as ready to be committed.

Mark Rowe (bdash)

Comment 2 2010-04-18 06:17:47 PDT

By the way, you can see <http://webkit.org/coding/contributing.html> for some more info about that.

Michael Forney

Comment 3 2010-04-18 12:50:23 PDT

Created attachment 53631 [details] Fixes the sandbox option Sorry about that. Here is an updated patch.

WebKit Review Bot

Comment 4 2010-04-18 12:54:58 PDT

Attachment 53631 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 ChangeLog:9: Line contains tab character. [whitespace/tab] [5] ChangeLog:10: Line contains tab character. [whitespace/tab] [5] ChangeLog:11: Line contains tab character. [whitespace/tab] [5] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Michael Forney

Comment 5 2010-04-18 15:19:25 PDT

Created attachment 53637 [details] Fixes the sandbox option Fixed the tabs.

Laszlo Gombos

Comment 6 2010-04-18 20:38:39 PDT

Comment on attachment 53637 [details] Fixes the sandbox option lgtm, r+.

WebKit Commit Bot

Comment 7 2010-04-18 21:08:39 PDT

Comment on attachment 53637 [details] Fixes the sandbox option Clearing flags on attachment: 53637 Committed r57801: <http://trac.webkit.org/changeset/57801>

WebKit Commit Bot

Comment 8 2010-04-18 21:08:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.