Bug 37748

Summary:

Make Sheriffbot more inspirational

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, cjerdonek, eric

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch with test cases	none
Patch	eric: review-
Patch with test cases	none

Daniel Bates

Reported 2010-04-16 23:04:15 PDT

Teach Sheriffbot some new quotes.

Attachments
Patch with test cases (6.80 KB, patch) 2010-04-19 19:53 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Patch (6.81 KB, patch) 2010-04-20 00:54 PDT, Daniel Bates	eric: review-	Details Formatted Diff Diff
Patch with test cases (6.77 KB, patch) 2010-04-20 01:43 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2010-04-19 19:53:50 PDT

Created attachment 53767 [details] Patch with test cases

Adam Barth

Comment 2 2010-04-19 21:27:00 PDT

Comment on attachment 53767 [details] Patch with test cases Awesome!

Daniel Bates

Comment 3 2010-04-19 21:34:35 PDT

Comment on attachment 53767 [details] Patch with test cases Clearing flags on attachment: 53767 Committed r57868: <http://trac.webkit.org/changeset/57868>

Daniel Bates

Comment 4 2010-04-19 21:34:41 PDT

All reviewed patches have been landed. Closing bug.

Daniel Bates

Comment 5 2010-04-19 22:13:13 PDT

Sheriffbot sat silently when you said hi after <http://trac.webkit.org/changeset/57868> :-(. Rolled out in <http://trac.webkit.org/changeset/57869> so that I can further test/debug the patch.

Daniel Bates

Comment 6 2010-04-20 00:54:08 PDT

Created attachment 53780 [details] Patch

Eric Seidel (no email)

Comment 7 2010-04-20 01:06:01 PDT

Comment on attachment 53780 [details] Patch Please add unicode to your test case. Seems fetch_ should just call parse_ internally, no? Then parse could be _parse? I'm surprised the convertEntities bit is needed. I wonder where else we might need that? BeatufifulSoup is a subclass of BeautifulStoneSoup, no need to import BeautifulStoneSoup just for HTML_ENTITIES. regexp strings shoudl start with r"

Daniel Bates

Comment 8 2010-04-20 01:43:45 PDT

Created attachment 53782 [details] Patch with test cases Updated patch based on Eric's comments.

Daniel Bates

Comment 9 2010-04-20 01:44:49 PDT

(In reply to comment #7) > (From update of attachment 53780 [details]) > [...] > I'm surprised the convertEntities bit is needed. I wonder where else we might > need that? I'll look into this further.

Eric Seidel (no email)

Comment 10 2010-04-20 01:46:57 PDT

Comment on attachment 53782 [details] Patch with test cases LGTM.

Daniel Bates

Comment 11 2010-04-20 20:55:10 PDT

Comment on attachment 53782 [details] Patch with test cases Clearing flags on attachment: 53782 Committed r57948: <http://trac.webkit.org/changeset/57948>

Daniel Bates

Comment 12 2010-04-20 20:55:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.