Bug 3771 – GW: Update create_hash_table closer to TOT KJS

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

This update brings support for the
-n <namespace>
addition as part of KDOM

This also (more importantly) adds support for for parsing more recent hashtable comments (w/o affecting 
support for exiting comments).

The only change left to merge into this file form TOT KJS is support for the separate "string tables" lookup 
for better hashtable memory locality (and possibly perf improvements.  That merger will have to be 
covered by another bug.

[Eric Seidel (no email)]

Created attachment 2712 [details]
relatively simple patch, which adds support to create_hash_table as detailed in the bug

[Eric Seidel (no email)]

Comment on attachment 2712 [details]
relatively simple patch, which adds support to create_hash_table as detailed in the bug

verified all test cases pass

[Darin Adler]

Comment on attachment 2712 [details]
relatively simple patch, which adds support to create_hash_table as detailed in the bug

I'd prefer to roll in the "string tables" change at the same time, myself.

I'm also not fond of comments that say "NEW", since they inevitably become
"OLD" :-)

I also don't like checking in commented-out debugging code.

And it's very strange to use this:

    ".$nameEntries."

when you one could just have said:

    $nameEntries

But these are minor quibbles -- seems fine to land this.

[Eric Seidel (no email)]

I removed the "NEW: " comment when committing.