Summary: | GW: Update create_hash_table closer to TOT KJS | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | JavaScriptCore | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P4 | ||||||
Version: | 412 | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 3250 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2005-06-30 02:34:51 PDT
Created attachment 2712 [details]
relatively simple patch, which adds support to create_hash_table as detailed in the bug
Comment on attachment 2712 [details]
relatively simple patch, which adds support to create_hash_table as detailed in the bug
verified all test cases pass
Comment on attachment 2712 [details]
relatively simple patch, which adds support to create_hash_table as detailed in the bug
I'd prefer to roll in the "string tables" change at the same time, myself.
I'm also not fond of comments that say "NEW", since they inevitably become
"OLD" :-)
I also don't like checking in commented-out debugging code.
And it's very strange to use this:
".$nameEntries."
when you one could just have said:
$nameEntries
But these are minor quibbles -- seems fine to land this.
I removed the "NEW: " comment when committing. |