Bug 37681

Summary:

Remove the main frame check when injecting v8 extensions into a script context

Product:

WebKit

Reporter:

Matt Perry <mpcomplete>

Component:

WebKit API

Assignee:

Matt Perry <mpcomplete>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows Vista

Attachments:

Description	Flags
simple patch	none

Matt Perry

Reported 2010-04-15 16:11:49 PDT

Previously we had restricted v8 extensions to script contexts where both the frame and its main frame had matched that extension's scheme restriction. I want to remove the main frame check. Chromium can make this check elsewhere, which gives us finer-grained control over what extensions run and what APIs are exposed to web content. This is related to Chromium bug http://code.google.com/p/chromium/issues/detail?id=37920 .

Attachments
simple patch (1.76 KB, patch) 2010-04-15 16:35 PDT, Matt Perry	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Matt Perry

Comment 1 2010-04-15 16:35:46 PDT

Created attachment 53486 [details] simple patch

Adam Barth

Comment 2 2010-04-15 17:08:11 PDT

Comment on attachment 53486 [details] simple patch Ok. I never liked that check. :) Grabbing the URL off the activeDocumentLoader is kind of scary, but is probably ok.

WebKit Commit Bot

Comment 3 2010-04-15 23:20:39 PDT

Comment on attachment 53486 [details] simple patch Clearing flags on attachment: 53486 Committed r57715: <http://trac.webkit.org/changeset/57715>

WebKit Commit Bot

Comment 4 2010-04-15 23:20:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.