|Summary:||Remove the main frame check when injecting v8 extensions into a script context|
|Product:||WebKit||Reporter:||Matt Perry <mpcomplete>|
|Component:||WebKit API||Assignee:||Matt Perry <mpcomplete>|
|Version:||528+ (Nightly build)|
Description Matt Perry 2010-04-15 16:11:49 PDT
Previously we had restricted v8 extensions to script contexts where both the frame and its main frame had matched that extension's scheme restriction. I want to remove the main frame check. Chromium can make this check elsewhere, which gives us finer-grained control over what extensions run and what APIs are exposed to web content. This is related to Chromium bug http://code.google.com/p/chromium/issues/detail?id=37920 .
Comment 2 Adam Barth 2010-04-15 17:08:11 PDT
Comment on attachment 53486 [details] simple patch Ok. I never liked that check. :) Grabbing the URL off the activeDocumentLoader is kind of scary, but is probably ok.
Comment 3 WebKit Commit Bot 2010-04-15 23:20:39 PDT
Comment on attachment 53486 [details] simple patch Clearing flags on attachment: 53486 Committed r57715: <http://trac.webkit.org/changeset/57715>
Comment 4 WebKit Commit Bot 2010-04-15 23:20:44 PDT
All reviewed patches have been landed. Closing bug.