|Summary:||Remove casts/constructors to/from JSC::UString type from WebCore::String|
|Product:||WebKit||Reporter:||Gavin Barraclough <barraclough>|
|Component:||Platform||Assignee:||Gavin Barraclough <barraclough>|
|Severity:||Normal||CC:||dglazkov, gns, webkit.review.bot, xan.lopez|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Gavin Barraclough 2010-04-15 14:21:20 PDT
WebCore's strings should not know about JSC::UString, this should be abstracted away in the bindings. Add explicit conversion methods rather than relying on overloaded cast operators / constructors being implicitly called.
Comment 2 WebKit Review Bot 2010-04-15 14:29:19 PDT
Attachment 53477 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/js/JSDOMBinding.h:26: Alphabetical sorting problem. [build/include_order]  WebCore/bindings/js/ScriptProfiler.cpp:31: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order]  Total errors found: 2 in 65 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-04-15 14:40:42 PDT
Comment on attachment 53477 [details] The patch I like the long names since it means we can find them all easily if we want to change it. r=me pending perf.
Comment 4 WebKit Review Bot 2010-04-15 15:24:17 PDT
Attachment 53477 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1688222
Comment 5 WebKit Review Bot 2010-04-15 16:22:17 PDT
Attachment 53477 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1658431
Comment 6 Gavin Barraclough 2010-04-15 20:39:01 PDT
Created attachment 53508 [details] Hopefully slightly better patch!
Comment 7 Oliver Hunt 2010-04-16 12:45:40 PDT
Comment on attachment 53508 [details] Hopefully slightly better patch! r=me
Comment 8 Gavin Barraclough 2010-04-16 13:26:28 PDT
Transmitting file data ......................................................................... Committed revision 57738.