Bug 37675

Summary: Remove casts/constructors to/from JSC::UString type from WebCore::String
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: PlatformAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
The patch
sam: review+
Hopefully slightly better patch! oliver: review+

Gavin Barraclough
Reported 2010-04-15 14:21:20 PDT
WebCore's strings should not know about JSC::UString, this should be abstracted away in the bindings. Add explicit conversion methods rather than relying on overloaded cast operators / constructors being implicitly called.
Attachments
The patch (76.92 KB, patch)
2010-04-15 14:25 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
Hopefully slightly better patch! (84.61 KB, patch)
2010-04-15 20:39 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2010-04-15 14:25:53 PDT
Created attachment 53477 [details] The patch
WebKit Review Bot
Comment 2 2010-04-15 14:29:19 PDT
Attachment 53477 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/bindings/js/JSDOMBinding.h:26: Alphabetical sorting problem. [build/include_order] [4] WebCore/bindings/js/ScriptProfiler.cpp:31: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 65 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-04-15 14:40:42 PDT
Comment on attachment 53477 [details] The patch I like the long names since it means we can find them all easily if we want to change it. r=me pending perf.
WebKit Review Bot
Comment 4 2010-04-15 15:24:17 PDT
Attachment 53477 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/1688222
WebKit Review Bot
Comment 5 2010-04-15 16:22:17 PDT
Attachment 53477 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/1658431
Gavin Barraclough
Comment 6 2010-04-15 20:39:01 PDT
Created attachment 53508 [details] Hopefully slightly better patch!
Oliver Hunt
Comment 7 2010-04-16 12:45:40 PDT
Comment on attachment 53508 [details] Hopefully slightly better patch! r=me
Gavin Barraclough
Comment 8 2010-04-16 13:26:28 PDT
Transmitting file data ......................................................................... Committed revision 57738.
Note You need to log in before you can comment on or make changes to this bug.