Remove casts/constructors to/from JSC::UString type from WebCore::String

• Component: Platform
• Status: RESOLVED FIXED

[Gavin Barraclough]

WebCore's strings should not know about JSC::UString, this should be abstracted away in the bindings.  Add explicit conversion methods rather than relying on overloaded cast operators / constructors being implicitly called.

[Gavin Barraclough]

Created attachment 53477 [details]
The patch

[WebKit Review Bot]

Attachment 53477 [details] did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/js/JSDOMBinding.h:26:  Alphabetical sorting problem.  [build/include_order] [4]
WebCore/bindings/js/ScriptProfiler.cpp:31:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 65 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 53477 [details]
The patch

I like the long names since it means we can find them all easily if we want to change it.  r=me pending perf.

[WebKit Review Bot]

Attachment 53477 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1688222

[WebKit Review Bot]

Attachment 53477 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/1658431

[Gavin Barraclough]

Created attachment 53508 [details]
Hopefully slightly better patch!

[Oliver Hunt]

Comment on attachment 53508 [details]
Hopefully slightly better patch!

r=me

[Gavin Barraclough]

Transmitting file data .........................................................................
Committed revision 57738.