Summary: | [v8] mark Array.prototype.sort tests which verify if sorting is stable as passing for Chromium | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | anton muhin <antonm> | ||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ager, ajwong, commit-queue, levin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
I would update the comment in test_expectation.txt because it is very confusing to see "// V8 doesn't stable sort and we currently have no intention of // changing this." Followed by two passing tests which are marked as WONTFIX! Reading your comment in this bug it completely makes sense. (In reply to comment #1) > I would update the comment in test_expectation.txt because it is very confusing > to see > "// V8 doesn't stable sort and we currently have no intention of > // changing this." > Followed by two passing tests which are marked as WONTFIX! > > Reading your comment in this bug it completely makes sense. :) David, if you have any suggestions how to make it more obvious, I'd really appreciate that. Perhaps: "// V8 doesn't stable sort and we currently have no intention of // changing this. The following test only happen to pass due to // the current algorithm used for sorting small arrays. If larger // arrays were used in the tests, they would fail." Created attachment 53442 [details]
Changing the wording per David suggestion
(In reply to comment #3) > Perhaps: > "// V8 doesn't stable sort and we currently have no intention of > // changing this. The following test only happen to pass due to > // the current algorithm used for sorting small arrays. If larger > // arrays were used in the tests, they would fail." Thanks, David, changed as per your suggestion. Comment on attachment 53442 [details]
Changing the wording per David suggestion
Thanks a lot, David
Comment on attachment 53442 [details] Changing the wording per David suggestion Clearing flags on attachment: 53442 Committed r57666: <http://trac.webkit.org/changeset/57666> All reviewed patches have been landed. Closing bug. |
Created attachment 53430 [details] First take Recently algorithm for sorting small arrays (<= 22 elements) was changed and now sorting for those arrays is stable. Note that larger arrays are sorted with quick sort, so sorting is not stable for them.