Bug 37635

Summary:

Spatial Navigation: make hasOffscreenRect() to earlier return 'true' if absoluteClippedOverflowRect() gives an empty rect

Product:

WebKit

Reporter:

Antonio Gomes <tonikitoo>

Component:

Accessibility

Assignee:

Antonio Gomes <tonikitoo>

Status:

CLOSED FIXED

Severity:

Normal

CC:

dglazkov, eric, gustavo, hausmann, kenneth, simon.fraser, webkit-ews, webkit.review.bot, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

All

Bug Depends on:

18662

Bug Blocks:

35784

Attachments:

Description	Flags
patch v1	tonikitoo: commit-queue-
(committed: r57663) patch v2	none

Description Antonio Gomes 2010-04-14 21:11:32 PDT

absoluteClippedOverflowRect implemention does return an empty rect for offscreen nodes. so hasOffscreenRect (SpatialNavigation.cpp) can bail out earlier in such cases.

see related discussion in webkit-dev in [1]

[1] http://lists.macosforge.org/pipermail/webkit-dev/2010-March/012075.html

Comment 1 Antonio Gomes 2010-04-14 21:17:04 PDT

Created attachment 53405 [details]
patch v1

Comment 2 WebKit Review Bot 2010-04-14 21:20:14 PDT

Attachment 53405 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/1591506

Comment 3 WebKit Review Bot 2010-04-14 21:23:12 PDT

Attachment 53405 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/1552523

Comment 4 Eric Seidel (no email) 2010-04-14 21:23:31 PDT

Attachment 53405 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/1689241

Comment 5 Early Warning System Bot 2010-04-14 21:24:44 PDT

Attachment 53405 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/1686255

Comment 6 Antonio Gomes 2010-04-15 08:15:05 PDT

Created attachment 53438 [details]
(committed: r57663) patch v2

same as patch v1, but un-bitrotted and builds

Comment 7 Antonio Gomes 2010-04-15 12:39:44 PDT

Comment on attachment 53438 [details]
(committed: r57663) patch v2

Clearing flags on attachment: 53438

Committed r57663: <http://trac.webkit.org/changeset/57663>

Comment 8 Antonio Gomes 2010-04-15 12:40:52 PDT

Thank you Simon Fraser!

Comment 9 Simon Hausmann 2010-04-20 13:22:10 PDT

Revision r57663 cherry-picked into qtwebkit-2.0 with commit bf61de5859ad29d41a76791862ac4c02b336d6da