Bug 37632

Summary: Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cjerdonek, dpranke, wsiegrist
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Updated patch which doesn't enable new-run-webkit-tests for any ports yet
none
Fix run-webkit-tests for users who don't have WebKitTools/Scripts in their path
none
Make run-webkit-tests exit non-zero if launching harness fails none

Eric Seidel (no email)
Reported 2010-04-14 20:28:37 PDT
Add a layer of indirection when calling run-webkit-tests to allow testing new-run-webkit-tests on various platforms without needing to change scripts or restart the buildbot master.
Attachments
Patch (163.26 KB, patch)
2010-04-14 20:37 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (169.54 KB, patch)
2010-04-14 22:50 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Updated patch which doesn't enable new-run-webkit-tests for any ports yet (169.91 KB, patch)
2010-04-16 14:59 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Fix run-webkit-tests for users who don't have WebKitTools/Scripts in their path (1.03 KB, patch)
2010-04-18 13:56 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Make run-webkit-tests exit non-zero if launching harness fails (1.14 KB, patch)
2010-04-18 14:10 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-04-14 20:37:41 PDT
Created attachment 53402 [details] Patch
Eric Seidel (no email)
Comment 2 2010-04-14 22:50:34 PDT
Created attachment 53413 [details] Patch
Eric Seidel (no email)
Comment 3 2010-04-16 14:59:05 PDT
Created attachment 53568 [details] Updated patch which doesn't enable new-run-webkit-tests for any ports yet
Dirk Pranke
Comment 4 2010-04-16 17:30:45 PDT
looks basically fine to me, but I'm not a reviewer.
Adam Barth
Comment 5 2010-04-17 13:23:28 PDT
Comment on attachment 53568 [details] Updated patch which doesn't enable new-run-webkit-tests for any ports yet Ok. The diff is hard to read, but it looks reasonable.
Eric Seidel (no email)
Comment 6 2010-04-18 13:34:42 PDT
Committed r57796: <http://trac.webkit.org/changeset/57796>
Eric Seidel (no email)
Comment 7 2010-04-18 13:36:57 PDT
Landed. Watching the bots now.
Eric Seidel (no email)
Comment 8 2010-04-18 13:56:57 PDT
Created attachment 53633 [details] Fix run-webkit-tests for users who don't have WebKitTools/Scripts in their path
Eric Seidel (no email)
Comment 9 2010-04-18 13:59:50 PDT
Committed r57798: <http://trac.webkit.org/changeset/57798>
Eric Seidel (no email)
Comment 10 2010-04-18 14:10:03 PDT
Created attachment 53634 [details] Make run-webkit-tests exit non-zero if launching harness fails
Eric Seidel (no email)
Comment 11 2010-04-18 14:26:00 PDT
Committed r57799: <http://trac.webkit.org/changeset/57799>
Note You need to log in before you can comment on or make changes to this bug.