Summary: | [WML] Duplicated patches were pushed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eric, zmo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Gyuyoung Kim
2010-04-13 19:04:18 PDT
Feel free to post a patch. :) Created attachment 53409 [details]
Fix build break
I attach a patch for this build fail.
Thanks.
Comment on attachment 53409 [details]
Fix build break
Are the current dummy implementations in the header the right ones? Do they need FIXMEs next to them?
Created attachment 53410 [details]
Patch for wml build break
I think so. I remove the dumy functions implemented in header file.
Comment on attachment 53410 [details]
Patch for wml build break
OK.
Comment on attachment 53410 [details] Patch for wml build break Rejecting patch 53410 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 12683 test cases. fast/canvas/webgl/index-validation.html -> failed Exiting early after 1 failures. 5085 tests run. 85.28s total testing time 5084 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/1722046 Hmm, I don't know why this patch makes test fail. If you know the reason, could you tell me the reason ? It's not your fault, it's a flaky test. Comment on attachment 53410 [details] Patch for wml build break Clearing flags on attachment: 53410 Committed r57639: <http://trac.webkit.org/changeset/57639> All reviewed patches have been landed. Closing bug. |