Summary: | [chromium] Provide access to a GL ES drawing context from WebCore | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Vangelis Kokkevis <vangelis> | ||||||||
Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, dglazkov, fishd, kbr, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Vangelis Kokkevis
2010-04-13 18:52:05 PDT
Created attachment 53307 [details]
Proposed patch
The implementation is there although I'm not particularly happy with the way I pass a pointer to the WebView in GLES2Context::initialize(). Essentially I pass it as a NULL pointer to WebCore code and cast it to WebKit::WebView in WebKit. Any suggestions on how to get around that issue would be greatly appreciated!
Attachment 53307 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/GLES2Context.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4]
WebKit/chromium/src/GLES2Context.cpp:122: One space before end of line comments [whitespace/comments] [5]
Total errors found: 2 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 53349 [details]
Proposed patch with style issues fixed
Updated patch although the issue with passing WebView around remains. Please see comment in previous patch. Thanks!
Created attachment 53492 [details]
Proposed patch
Fixed previous issue with passing around the WebView pointer
Attachment 53492 [details] did not pass style-queue:
Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/chromium/src/GLES2Context.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4]
WebKit/chromium/src/GLES2Context.cpp:119: One space before end of line comments [whitespace/comments] [5]
Total errors found: 2 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 53492 [details]
Proposed patch
lgtm.
Comment on attachment 53492 [details] Proposed patch Clearing flags on attachment: 53492 Committed r57780: <http://trac.webkit.org/changeset/57780> All reviewed patches have been landed. Closing bug. |