Bug 37541

Summary:

[chromium] Provide access to a GL ES drawing context from WebCore

Product:

WebKit

Reporter:

Vangelis Kokkevis <vangelis>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, fishd, kbr, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	none
Proposed patch with style issues fixed	none
Proposed patch	none

Vangelis Kokkevis

Reported 2010-04-13 18:52:05 PDT

The hardware accelerated compositor in WebCore's platform/graphics/chromium needs to have access to an OGL ES context in order to execute GL commands. It cannot create the context directly itself so it must proxy the task back to the browser.

Attachments
Proposed patch (13.61 KB, patch) 2010-04-13 19:24 PDT, Vangelis Kokkevis	no flags	Details Formatted Diff Diff
Proposed patch with style issues fixed (13.61 KB, patch) 2010-04-14 12:21 PDT, Vangelis Kokkevis	no flags	Details Formatted Diff Diff
Proposed patch (13.54 KB, patch) 2010-04-15 17:17 PDT, Vangelis Kokkevis	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Vangelis Kokkevis

Comment 1 2010-04-13 19:24:42 PDT

Created attachment 53307 [details] Proposed patch The implementation is there although I'm not particularly happy with the way I pass a pointer to the WebView in GLES2Context::initialize(). Essentially I pass it as a NULL pointer to WebCore code and cast it to WebKit::WebView in WebKit. Any suggestions on how to get around that issue would be greatly appreciated!

WebKit Review Bot

Comment 2 2010-04-13 19:25:54 PDT

Attachment 53307 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/GLES2Context.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4] WebKit/chromium/src/GLES2Context.cpp:122: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Vangelis Kokkevis

Comment 3 2010-04-14 12:21:30 PDT

Created attachment 53349 [details] Proposed patch with style issues fixed Updated patch although the issue with passing WebView around remains. Please see comment in previous patch. Thanks!

Vangelis Kokkevis

Comment 4 2010-04-15 17:17:28 PDT

Created attachment 53492 [details] Proposed patch Fixed previous issue with passing around the WebView pointer

WebKit Review Bot

Comment 5 2010-04-15 17:23:31 PDT

Attachment 53492 [details] did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/chromium/src/GLES2Context.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4] WebKit/chromium/src/GLES2Context.cpp:119: One space before end of line comments [whitespace/comments] [5] Total errors found: 2 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dimitri Glazkov (Google)

Comment 6 2010-04-16 09:11:16 PDT

Comment on attachment 53492 [details] Proposed patch lgtm.

WebKit Commit Bot

Comment 7 2010-04-17 07:55:38 PDT

Comment on attachment 53492 [details] Proposed patch Clearing flags on attachment: 53492 Committed r57780: <http://trac.webkit.org/changeset/57780>

WebKit Commit Bot

Comment 8 2010-04-17 07:55:44 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.