Bug 37533

Summary: [Chromium] UniscribeHelper::draw() should not ASSERT that ScriptTextOut always succeeds
Product: WebKit Reporter: Dumitru Daniliuc <dumi>
Component: New BugsAssignee: Dumitru Daniliuc <dumi>
Status: RESOLVED FIXED    
Severity: Normal CC: brettw, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch jianli: review+, dumi: commit-queue-

Dumitru Daniliuc
Reported 2010-04-13 17:10:44 PDT
UniscribeHelper::draw() should not ASSERT that ScriptTextOut() always succeed. It even has logic to deal with this kind of failures.
Attachments
patch (1.26 KB, patch)
2010-04-13 17:12 PDT, Dumitru Daniliuc 		jianli: review+
dumi: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dumitru Daniliuc
Comment 1 2010-04-13 17:12:45 PDT
Created attachment 53302 [details] patch
Brett Wilson (Google)
Comment 2 2010-04-13 17:55:10 PDT
For background, we probably used to have a DCHECK here with is a debug-only assert to help catch errors. However, there are legitimate reasons this function may fail, especially in the Chrome sandbox, which is what the existing recovery code is supposed to do.
Jian Li
Comment 3 2010-04-13 23:49:14 PDT
Comment on attachment 53302 [details] patch r=me
Dumitru Daniliuc
Comment 4 2010-04-14 12:44:49 PDT
Landed as r57595.
Eric Seidel (no email)
Comment 5 2010-04-14 14:50:02 PDT
fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes.html has been failing consistently on SnowLeopard since this checkin: http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r57603%20(5978)/fast/dom/Window/HTMLFrameSetElement-window-eventListener-attributes-stderr.txt ASSERTION FAILED: m_wrapper || !m_jsFunction (/Volumes/Data/WebKit-BuildSlave/snowleopard-intel-leaks/build/WebCore/bindings/js/JSEventListener.h:83 JSC::JSObject* WebCore::JSEventListener::jsFunction(WebCore::ScriptExecutionContext*) const) That's the same ASSERT as bug 36779, except now its failing every time.
Eric Seidel (no email)
Comment 6 2010-04-14 14:52:11 PDT
Nevermind, this test is flakey and has been failing for much longer.
Note You need to log in before you can comment on or make changes to this bug.