Bug 37525

Summary: Make failure-reason more forgiving
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch aroben: review+

Eric Seidel (no email)
Reported 2010-04-13 15:15:42 PDT
Make failure-reason more forgiving
Attachments
Patch (4.51 KB, patch)
2010-04-13 15:20 PDT, Eric Seidel (no email) 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-04-13 15:20:30 PDT
Created attachment 53286 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-04-13 21:51:45 PDT
Comment on attachment 53286 [details] Patch > + # FIXME: This could be made more user friendly. > + print "Failed to load layout test results start revision r%s, can't continue." % start_revision I think this would be a little clearer like this: "Failed to load layout test results; can't continue. (start revision = r%s)" > @@ -237,8 +243,10 @@ class FailureReason(AbstractDeclarativeCommand): > results_to_explain -= fixed_results > if results_to_explain: > print "Failed to explain failures: %s" % results_to_explain > + return 1 > else: > print "Explained all results for %s" % builder.name() > + return 0 Our C++ style is not to use "else" after "return". r=me
Eric Seidel (no email)
Comment 3 2010-04-13 21:57:14 PDT
Comment on attachment 53286 [details] Patch Oooh, good suggestions. Will do.
Eric Seidel (no email)
Comment 4 2010-04-18 16:29:43 PDT
Attachment 53286 [details] was posted by a committer and has review+, assigning to Eric Seidel for commit.
Eric Seidel (no email)
Comment 5 2010-04-18 23:36:58 PDT
Committed r57805: <http://trac.webkit.org/changeset/57805>
Note You need to log in before you can comment on or make changes to this bug.