Summary: | Make failure-reason more forgiving | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Eric Seidel (no email) <eric> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2010-04-13 15:15:42 PDT
Created attachment 53286 [details]
Patch
Comment on attachment 53286 [details] Patch > + # FIXME: This could be made more user friendly. > + print "Failed to load layout test results start revision r%s, can't continue." % start_revision I think this would be a little clearer like this: "Failed to load layout test results; can't continue. (start revision = r%s)" > @@ -237,8 +243,10 @@ class FailureReason(AbstractDeclarativeCommand): > results_to_explain -= fixed_results > if results_to_explain: > print "Failed to explain failures: %s" % results_to_explain > + return 1 > else: > print "Explained all results for %s" % builder.name() > + return 0 Our C++ style is not to use "else" after "return". r=me Comment on attachment 53286 [details]
Patch
Oooh, good suggestions. Will do.
Attachment 53286 [details] was posted by a committer and has review+, assigning to Eric Seidel for commit.
Committed r57805: <http://trac.webkit.org/changeset/57805> |