Bug 37518 – new-run-webkit-websocketserver failed to launch on Win

• Component: Tools / Tests
• Status: NEW

[Fumitoshi Ukai]

new-run-webkit-websocketserver failed to launch on Win/Python 2.4 (ui_tests in chromium)

http://build.chromium.org/buildbot/try-server/builders/win/builds/27804/steps/ui_tests/logs/stdio
[ RUN      ] WorkerTest.WorkerWebSocketLayoutTests
Traceback (most recent call last):
  File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\new-run-webkit-websocketserver", line 91, in ?
    main()
  File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\new-run-webkit-websocketserver", line 82, in main
    port_obj = factory.get()
  File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\factory.py", line 69, in get
    import win
  File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\win.py", line 35, in ?
    from webkitpy.layout_tests.port.webkit import WebKitPort
  File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\webkit.py", line 46, in ?
    import webkitpy.layout_tests.port.server_process as server_process
  File "c:\b\slave\win\build\src\third_party\WebKit\WebKitTools\Scripts\webkitpy\layout_tests\port\server_process.py", line 32, in ?
    import fcntl
ImportError: No module named fcntl

[Adam Barth]

fcntl only exists on Unix.  We need to either remove this dependency or figure out a windows equivalent.

[Fumitoshi Ukai]

Created attachment 54042 [details]
Patch

[Adam Barth]

Comment on attachment 54042 [details]
Patch

WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py:46
 +      from win32pipe import PeekNamedPipe
Can we abstract this functionality into some kind of library instead of having these ifs all over the place?

WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py:83
 +              fd = self._proc.stdout.fileno()
Please use more verbose variable names.  I have no idea what this code is doing.

WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py:206
 +      def _select(self, rlist, wlist, xlist, timeout):
Again, these argument names are incomprehensible.

WebKitTools/Scripts/webkitpy/layout_tests/port/server_process.py:222
 +              time.sleep(0.1)
Do we really need this sleep loop?  This seems janky.