Bug 37499

Summary: Web Inspector: Cannot effectively delete properties in the Styles sidebar pane
Product: WebKit Reporter: Alexander Pavlov (apavlov) <apavlov>
Component: Web Inspector (Deprecated)Assignee: Alexander Pavlov (apavlov) <apavlov>
Status: RESOLVED FIXED    
Severity: Normal CC: bweinstein, commit-queue, eric, joepeck, keishi, pfeldman, pmuellr, rik, timothy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Trivial fix none

Description Alexander Pavlov (apavlov) 2010-04-13 06:50:30 PDT 
Style properties disappear in the pane when deleted, but effectively they remain in the respective stylesheet and appear in the pane if the Web Inspector is re-opened.
Comment 1 Alexander Pavlov (apavlov) 2010-04-13 07:12:35 PDT 
Created attachment 53244 [details]
[PATCH] Trivial fix
Comment 2 Joseph Pecoraro 2010-04-13 07:18:11 PDT 
Comment on attachment 53244 [details]
[PATCH] Trivial fix

Nice!
Comment 3 Joseph Pecoraro 2010-04-13 07:19:56 PDT 
Hmm, I am not a Reviewer yet in commiters.py. So if this fails I will take care of things (either having someone else mark these flags, landing myself, or updating commiters.py).
Comment 4 WebKit Commit Bot 2010-04-13 07:20:59 PDT 
Comment on attachment 53244 [details]
[PATCH] Trivial fix

Rejecting patch 53244 from review queue.

joepeck@webkit.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  Due to bug 30084 the commit-queue will require a restart after your change.  Please contact eseidel@chromium.org to request a commit-queue restart.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 5 Pavel Feldman 2010-04-13 07:22:56 PDT 
It would be great to have a test for this one.
Comment 6 WebKit Commit Bot 2010-04-13 07:37:03 PDT 
Comment on attachment 53244 [details]
[PATCH] Trivial fix

Clearing flags on attachment: 53244

Committed r57514: <http://trac.webkit.org/changeset/57514>
Comment 7 WebKit Commit Bot 2010-04-13 07:37:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Eric Seidel (no email) 2010-04-13 13:27:11 PDT 
Joe is still listed as a committer:
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py#L122
Comment 9 Eric Seidel (no email) 2010-04-13 13:30:31 PDT 
Joe, you'll need to update committers.py, moving your entry from committers to reviewers if you're not a reviewer.